Arm backend: Replace asserts/raises with reporter rejects #14371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- embedding_support: replace input-count assert with reporter.report_reject + return False - index_tensor_support: add explicit rejects for None in indices, rank >= 4 indexing tensors, and int32 overflow of value tensor; previously returned False without explanation - minmax_support: add reject when min/max.dim’s argmax output is used - ethos_u55_support: replace IndexError raises in view/select checks (invalid dim/index) with reporter.report_reject + return False - Improves partition diagnostics and avoids hard crashes Change-Id: I633e66441de2e3416d0f2b5d06d9ea46c43112fe Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14371
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1ffa843 with merge base bc18834 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
digantdesai
reviewed
Sep 17, 2025
| # it will be decomposed into ops that can handle it. | ||
|
|
||
| if len(node.all_input_nodes) != 2: | ||
| self.reporter.report_reject( |
digantdesai
approved these changes
Sep 17, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
) - embedding_support: replace input-count assert with reporter.report_reject + return False - index_tensor_support: add explicit rejects for None in indices, rank >= 4 indexing tensors, and int32 overflow of value tensor; previously returned False without explanation - minmax_support: add reject when min/max.dim’s argmax output is used - ethos_u55_support: replace IndexError raises in view/select checks (invalid dim/index) with reporter.report_reject + return False - Improves partition diagnostics and avoids hard crashes Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218