Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Align with minimal examples with regards to content and code.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Align with minimal examples with regards to content and code.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
(cherry picked from commit d25c35a)
Copy link

pytorch-bot bot commented Sep 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14372

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 52ac6fb with merge base e0dda90 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025

```
# In ExecuTorch top-level, with sourced setup_path.sh
cmake -DCMAKE_TOOLCHAIN_FILE=`pwd`/examples/arm/ethos-u-setup/arm-none-eabi-gcc.cmake \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, this can get outdated

The example below shows how to quantize a model consisting of a single addition, and export it it through the AOT flow using the EthosU backend. For more details, see `examples/arm/ethos_u_minimal_example.ipynb`.

```python
import torch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is just moved, but why leave so much code in a readme? Just refer to the linked notebook here? Can we link a cell for reference? Just so we can be precise about what we are talking about in the doc.

backends-mps
backends-vulkan
backends-arm-ethos-u
backends-arm-vgf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this an oversight in a previous PR?

Building an ExecuTorch Android Demo App <https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app>
Building an ExecuTorch iOS Demo App <https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo>
tutorial-arm.md
tutorial-arm-ethos-u
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is referring to these pages?

@GregoryComer
Copy link
Member

@digantdesai Do you have any concerns for merging this cherry-pick PR as is?

@zingo zingo added the module: arm Issues related to arm backend label Sep 18, 2025
@zingo zingo added this to the 1.0.0 milestone Sep 18, 2025
@digantdesai
Copy link
Contributor

@digantdesai Do you have any concerns for merging this cherry-pick PR as is?

Yeah I am good with merging. And also cherry-picking (as long as the content lines up with what's in 1.0).

@GregoryComer GregoryComer merged commit 878b03b into release/1.0 Sep 18, 2025
129 of 131 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14299-by-pytorch_bot_bot_ branch September 18, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants