Skip to content

Remove generic versions of aten ops and use portable instead #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Remove generic versions of aten ops and use portable instead #14389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backends/cadence/aot/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,7 @@ executorch_generated_lib(
deps = [
"//executorch/backends/cadence/generic/kernels:cadence_kernels",
# Individual operator targets instead of combined cadence_generic_ops
"//executorch/backends/cadence/generic/operators:op_add",
"//executorch/backends/cadence/generic/operators:op_embedding",
"//executorch/backends/cadence/generic/operators:op_full",
"//executorch/backends/cadence/generic/operators:op_requantize_out",
"//executorch/backends/cadence/generic/operators:op_view_copy",
"//executorch/backends/cadence/generic/operators:im2row_out",
"//executorch/backends/cadence/generic/operators:dequantize_per_tensor",
"//executorch/backends/cadence/generic/operators:quantize_per_tensor",
Expand Down
8 changes: 4 additions & 4 deletions backends/cadence/generic/operators/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ include(${EXECUTORCH_ROOT}/tools/cmake/Codegen.cmake)

# ATen compliant ops that are needed to run this model.
set(_aten_ops__srcs
"${CMAKE_CURRENT_SOURCE_DIR}/op_add.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/op_embedding.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/op_full.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/op_view_copy.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/activation_ops_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/copy_ops_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/broadcast_util.cpp"
Expand All @@ -31,10 +27,13 @@ set(_aten_ops__srcs
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/repeat_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/slice_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/pattern/unary_ufunc_realhbbf16_to_floathbf16.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_add.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_bmm.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_cat.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_clone.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_div.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_embedding.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_full.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_hardtanh.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_max_pool2d_with_indices.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_mean.cpp"
Expand All @@ -58,6 +57,7 @@ set(_aten_ops__srcs
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_native_group_norm.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_sum.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_select_copy.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/op_view_copy.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/dtype_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/normalization_ops_util.cpp"
"${EXECUTORCH_ROOT}/kernels/portable/cpu/util/select_copy_util.cpp"
Expand Down
61 changes: 0 additions & 61 deletions backends/cadence/generic/operators/op_add.cpp
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions backends/cadence/generic/operators/op_embedding.cpp
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions backends/cadence/generic/operators/op_full.cpp
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions backends/cadence/generic/operators/op_view_copy.cpp
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions backends/cadence/generic/operators/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,64 +4,6 @@ load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
def define_common_targets():
# Individual operator targets with optimized dependencies

# Basic operators (need broadcast_util and scalar_utils)
runtime.cxx_library(
name = "op_add",
srcs = ["op_add.cpp"],
platforms = CXX,
deps = [
"//executorch/kernels/portable/cpu/util:broadcast_util",
"//executorch/runtime/kernel:kernel_includes",
"//executorch/kernels/portable/cpu:scalar_utils",
],
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
)

runtime.cxx_library(
name = "op_full",
srcs = ["op_full.cpp"],
platforms = CXX,
deps = [
"//executorch/runtime/kernel:kernel_includes",
"//executorch/kernels/portable/cpu:scalar_utils",
],
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
)

# Simple operators (only need kernel_includes)
runtime.cxx_library(
name = "op_embedding",
srcs = ["op_embedding.cpp"],
platforms = CXX,
deps = [
"//executorch/runtime/kernel:kernel_includes",
],
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
)

runtime.cxx_library(
name = "op_view_copy",
srcs = ["op_view_copy.cpp"],
platforms = CXX,
deps = [
"//executorch/runtime/kernel:kernel_includes",
],
visibility = [
"//executorch/backends/cadence/...",
"@EXECUTORCH_CLIENTS",
],
)

# Operators that need the operators.h header and basic runtime
runtime.cxx_library(
name = "im2row_out",
srcs = ["im2row_out.cpp"],
Expand Down
Loading