Fix message truncating logic to respect UTF8 encoding. #14394

shoumikhin · 2025-09-17T22:23:03Z

Summary: .

Differential Revision: D82681904

pytorch-bot · 2025-09-17T22:23:07Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14394

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 5e2f1a0 with merge base a1ed4ed ():

NEW FAILURE - The following job has failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t e4f81f4edfeb6459939c068da483910069e916a7c36f26d3089b0263d0376884 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-09-17T22:23:21Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

github-actions · 2025-09-17T22:23:53Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: . Reviewed By: metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-17T23:14:22Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

runtime/platform/log.cpp

Summary: . Reviewed By: metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T02:33:19Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T02:51:32Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T03:08:18Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T05:35:40Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

swolchok

looks reasonable, please at least test truncating in the middle of a 2-byte codepoint

runtime/platform/log.cpp

runtime/platform/test/logging_test.cpp

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T16:55:49Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T17:01:45Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

facebook-github-bot · 2025-09-18T17:01:57Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T17:49:25Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T19:04:05Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T19:12:24Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

facebook-github-bot · 2025-09-18T19:13:50Z

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82681904.

shoumikhin · 2025-09-20T00:22:06Z

@pytorchbot cherry-pick --onto release/1.0 -c critical

(cherry picked from commit 2640a86)

pytorchbot · 2025-09-20T00:24:34Z

Cherry picking #14394

The cherry pick PR is at #14452 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

[v1.0.0] Release Tracker #14288 (comment)

Details for Dev Infra team

Raised by workflow job

(cherry picked from commit 2640a86)

shoumikhin requested review from JacobSzwejbka, lucylq and swolchok as code owners September 17, 2025 22:23

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025

facebook-github-bot added fb-exported meta-exported labels Sep 17, 2025

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 17, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

5e42ea8

Summary: . Reviewed By: metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from d8ea250 to 5e42ea8 Compare September 17, 2025 23:14

swolchok requested changes Sep 18, 2025

View reviewed changes

runtime/platform/log.cpp Show resolved Hide resolved

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

a4ab6f1

Summary: . Reviewed By: metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from 5e42ea8 to a4ab6f1 Compare September 18, 2025 02:33

shoumikhin requested review from larryliu0820 and kirklandsign as code owners September 18, 2025 02:33

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

466ac49

Summary: . Reviewed By: metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from a4ab6f1 to 466ac49 Compare September 18, 2025 02:51

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

7c5ca31

Summary: . Reviewed By: metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from 466ac49 to 7c5ca31 Compare September 18, 2025 03:08

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

200f125

Summary: . Reviewed By: metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from 7c5ca31 to 200f125 Compare September 18, 2025 05:35

swolchok approved these changes Sep 18, 2025

View reviewed changes

runtime/platform/log.cpp Outdated Show resolved Hide resolved

runtime/platform/test/logging_test.cpp Show resolved Hide resolved

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

0e7ee0a

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from 200f125 to 0e7ee0a Compare September 18, 2025 16:55

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

a9634b6

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from 0e7ee0a to a9634b6 Compare September 18, 2025 17:01

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

f61aaee

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from a9634b6 to f61aaee Compare September 18, 2025 17:01

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

f46a5e5

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from f61aaee to f46a5e5 Compare September 18, 2025 17:48

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

f4ba479

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from f46a5e5 to f4ba479 Compare September 18, 2025 19:03

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 18, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

bda587a

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from f4ba479 to bda587a Compare September 18, 2025 19:12

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

5e2f1a0

Summary: . Reviewed By: swolchok, metascroy Differential Revision: D82681904

shoumikhin force-pushed the export-D82681904 branch from bda587a to 5e2f1a0 Compare September 18, 2025 19:13

shoumikhin merged commit 2640a86 into pytorch:main Sep 18, 2025
124 of 128 checks passed

pytorchbot pushed a commit that referenced this pull request Sep 20, 2025

Fix message truncating logic to respect UTF8 encoding. (#14394)

c5778f5

(cherry picked from commit 2640a86)

pytorchbot mentioned this pull request Sep 20, 2025

[v1.0.0] Release Tracker #14288

Open

abhinaykukkadapu pushed a commit that referenced this pull request Sep 23, 2025

Fix message truncating logic to respect UTF8 encoding. (#14394)

9398c21

(cherry picked from commit 2640a86)

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025

Fix message truncating logic to respect UTF8 encoding. (pytorch#14394)

8124510

Fix message truncating logic to respect UTF8 encoding. #14394

Fix message truncating logic to respect UTF8 encoding. #14394

Uh oh!

Conversation

shoumikhin commented Sep 17, 2025

Uh oh!

pytorch-bot bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14394

❌ 1 New Failure, 1 Unrelated Failure

Uh oh!

facebook-github-bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Sep 17, 2025

Uh oh!

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

swolchok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

facebook-github-bot commented Sep 18, 2025

Uh oh!

Uh oh!

shoumikhin commented Sep 20, 2025

Uh oh!

pytorchbot commented Sep 20, 2025

Cherry picking #14394

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 17, 2025 •

edited

Loading

This PR needs a `release notes:` label