Skip to content

Fix timm installation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix timm installation #144

wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

Summary: bug fix

Reviewed By: larryliu0820

Differential Revision: D48697288

@guangy10 @facebook-github-bot
Fix timm installation
604972b 
Summary: bug fix

Reviewed By: larryliu0820

Differential Revision: D48697288

fbshipit-source-id: 6cc2e411fb09ea42d15c94ea5cd7cb72db6b75ef
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48697288

@guangy10
Copy link
Contributor Author

I think the bug can be landed in the first place is because of our CI is using a separate script to install all the required packages. I know @huydhn have set up good separation between the package versions and nightly versions. However, it's only used by the CI atm. I think we should unify the package installation script to have a single source of truth so that CI would catch up bugs like this in the future.

@huydhn
Copy link
Contributor

huydhn commented Aug 25, 2023

I think the bug can be landed in the first place is because of our CI is using a separate script to install all the required packages. I know @huydhn have set up good separation between the package versions and nightly versions. However, it's only used by the CI atm. I think we should unify the package installation script to have a single source of truth so that CI would catch up bugs like this in the future.

This should be achievable by calling those existing function from https://github.com/pytorch/executorch/blob/main/.ci/scripts/utils.sh#L8-L40 I think

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 17fa8f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guangy10 @facebook-github-bot @huydhn