-
Notifications
You must be signed in to change notification settings - Fork 683
Arm backend: Enable run on vulkan runtime by default and add xfails #14462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Iebf2f2a6a38f8540fafc3f43967e32d1261c89f8
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14462
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 69dd7b7 with merge base 5ae40f1 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
aten_op: str | List[str], | ||
exir_op: Optional[str | List[str]] = None, | ||
run_on_vulkan_runtime: bool = False, | ||
run_on_vulkan_runtime: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should spin vk tests in a different CI job? @zingo refactored Ethos ones perhaps he has an opinion ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Its a plan do it soon, @Michiel-Olieslagers is testing this first in our Arm internal CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So essentially this is not even running in CI yet. Only in our internal CI. And yeah the plan is to do it soon for sure..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway regardless of this split we would still have run on vulkan runtime eq true here. The same way as run_on_fvp is true by default now. Essentially it just means before most VGF tests failed and now most are passing.
Arm oobt fail is fixed in another PR |
Enables runing on vulkan runtime by default and add xfails for those tests that can not yet run.
cc @SS-JIA @manuelcandales @cbilgin @digantdesai @freddan80 @per @zingo @oscarandersson8218