Skip to content

Conversation

mansnils
Copy link
Collaborator

@mansnils mansnils commented Sep 22, 2025

Enables runing on vulkan runtime by default and add xfails for those tests that can not yet run.

cc @SS-JIA @manuelcandales @cbilgin @digantdesai @freddan80 @per @zingo @oscarandersson8218

Change-Id: Iebf2f2a6a38f8540fafc3f43967e32d1261c89f8
@mansnils mansnils added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 22, 2025
@mansnils mansnils added ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Sep 22, 2025
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Sep 22, 2025
Copy link

pytorch-bot bot commented Sep 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14462

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 69dd7b7 with merge base 5ae40f1 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2025
aten_op: str | List[str],
exir_op: Optional[str | List[str]] = None,
run_on_vulkan_runtime: bool = False,
run_on_vulkan_runtime: bool = True,
Copy link
Contributor

@digantdesai digantdesai Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should spin vk tests in a different CI job? @zingo refactored Ethos ones perhaps he has an opinion ..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Its a plan do it soon, @Michiel-Olieslagers is testing this first in our Arm internal CI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So essentially this is not even running in CI yet. Only in our internal CI. And yeah the plan is to do it soon for sure..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway regardless of this split we would still have run on vulkan runtime eq true here. The same way as run_on_fvp is true by default now. Essentially it just means before most VGF tests failed and now most are passing.

@zingo
Copy link
Collaborator

zingo commented Sep 24, 2025

Arm oobt fail is fixed in another PR

@zingo zingo merged commit 16ced4e into pytorch:main Sep 24, 2025
285 of 292 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants