Skip to content

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Sep 22, 2025

This removes a reference to the binary tree in the install tree.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: I3217fbfa005b317080ca030774153002a5901546
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 22, 2025
Copy link

pytorch-bot bot commented Sep 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14465

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 6fa0a43 with merge base b7ac647 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2025
@AdrianLundell AdrianLundell added the release notes: none Do not include this in the release notes label Sep 23, 2025
@AdrianLundell
Copy link
Collaborator Author

Fails does not look related

TARGETS extension_runner_util
EXPORT ExecuTorchTargets
DESTINATION ${CMAKE_BINARY_DIR}/lib
DESTINATION lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention is to install the lib in CMAKE_INSTALL_PREFIX instead of the binary dir, if someone has a reason for placing it there they can make sure to set CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX but I don't see why it would be a requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, but if the CI is green then I guess this is OK. Let me add trunk just to be sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

"${CMAKE_CURRENT_LIST_DIR}/../../cmake-out/extension/runner_util/libextension_runner_util.a"

Copy link
Collaborator Author

@AdrianLundell AdrianLundell Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should only affect the install tree so if you want to use the build tree library instead that should still be in the same place, in the Arm example we use FindPackage to avoid direct paths and that works well.

The reason why we want to make this change is to make it possible to move around the install tree without braking anything, for example to help parallelizing testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Thanks.

@zingo zingo merged commit 2d54207 into pytorch:main Sep 29, 2025
356 of 366 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants