Arm backend: Add dtype check for aten.where in operator support check #14506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, aten.where with non-quantized FP inputs can pass the the operator support check in INT profile, get partitioned, and then be removed from the partition due to FP inputs. - This will introduce dependency cycles, an invalid re-entry pattern `partition -> outside -> partition`, to the graph. - Workaround: when aten.where(cond, x, y) has FP x and y in INT profile, only partition if both come from dequantize ops (DQ_OPS). Note this may over-reject cases like `dq -> op1 -> aten.where -> q` that could be partitioned. - Don't partition aten.where with unsupported input dtype in FP profle. Change-Id: I0cef30ffe36eeb6d9c8fae7618649292df242887 Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14506
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 62a1cb4 with merge base ab31007 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
digantdesai
approved these changes
Sep 23, 2025
|
Arm oobt fail is unrelated and will be fixed by another PR |
|
@pytorchbot cherry-pick --onto release/1.0 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 24, 2025
…#14506) - Previously, aten.where with non-quantized FP inputs can pass the the operator support check in INT profile, get partitioned, and then be removed from the partition due to FP inputs. - This will introduce dependency cycles, an invalid re-entry pattern `partition -> outside -> partition`, to the graph. - Workaround: when aten.where(cond, x, y) has FP x and y in INT profile, only partition if both come from dequantize ops (DQ_OPS). Note this may over-reject cases like `dq -> op1 -> aten.where -> q` that could be partitioned. - Don't partition aten.where with unsupported input dtype in FP profle. Signed-off-by: Yufeng Shi <yufeng.shi@arm.com> (cherry picked from commit df5bfd5)
Cherry picking #14506The cherry pick PR is at #14539 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, aten.where with non-quantized FP inputs can pass the the operator support check in INT profile, get partitioned, and then be removed from the partition due to FP inputs.
This will introduce dependency cycles, an invalid re-entry pattern
partition -> outside -> partition, to the graph.Workaround: when aten.where(cond, x, y) has FP x and y in INT profile, only partition if both come from dequantize ops (DQ_OPS). Note this may over-reject cases like
dq -> op1 -> aten.where -> qthat could be partitioned.Don't partition aten.where with unsupported input dtype in FP profle.
Change-Id: I0cef30ffe36eeb6d9c8fae7618649292df242887
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218