Skip to content

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Sep 23, 2025

Note that tests are currently failing, comparing for example the call to arm_elementwise_add_s8 in op_quantized_add.cpp

arm_cmsis_nn_status status = arm_elementwise_add_s8(
with the definition in CMSIS-NN
https://github.com/ARM-software/CMSIS-NN/blob/88f1982a69c00ed13dd633a63da1009c48abbb4d/Include/arm_nnfunctions.h#L1923 it seems that the args are listed in the wrong order. This will be fixed in a future patch.

Minor fixes to get this to work:

  • Add init file to make test names unique
  • Update conftest to not crash is_option_enabled for tests running from external folder

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Note that tests are currently failing, comparing for example the
call to arm_elementwise_add_s8 in op_quantized_add.cpp
https://github.com/pytorch/executorch/blob/ab3100715afd21e5f0cee48675d9187152775d86/backends/cortex_m/ops/op_quantized_add.cpp#L88
with the definition in CMSIS-NN
https://github.com/ARM-software/CMSIS-NN/blob/88f1982a69c00ed13dd633a63da1009c48abbb4d/Include/arm_nnfunctions.h#L1923
it seems that the args are listed in the wrong order.
This will be fixed in a future patch.

Minor fixes to get this to work:
- Add init file to make test names unique
- Update conftest to not crash is_option_enabled for tests running
  from external folder

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: I7962fea42994d51f871c8789b0d58b98d60a2739
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 23, 2025
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14510

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 364ef50 with merge base ab31007 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

from executorch.backends.test.suite.operators.test_add import Model, ModelAlpha


class SelfAdd(torch.nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class SelfAdd(torch.nn.Module):
class SelfCortexMAdd(torch.nn.Module):

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added CortexM as a prefix to all models here instead, I prefer to keep to one same naming scheme and not put the target description part of the name (CortexM) in the middle of the model description part (SelfAdd).

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get the ball rolling.. thanks.

@digantdesai digantdesai requested a review from psiddh September 23, 2025 15:24
Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: Ib98d19bf53f26c1dec103b9e875080b495c6fbaf
@AdrianLundell
Copy link
Collaborator Author

I have not added buck targets in this PR since it is a new structure which makes it difficult to guess how it should look, but if you add it to this one I can follow that pattern for upcoming PR:s.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
@digantdesai
Copy link
Contributor

@psiddh - do you want to introduce buck targets here?

@psiddh
Copy link
Contributor

psiddh commented Sep 26, 2025

@psiddh - do you want to introduce buck targets here?

@AdrianLundell Once you land this PR , I can add the buck targets to it as a follow up

@zingo zingo merged commit d5c29ff into pytorch:main Sep 26, 2025
126 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants