-
Notifications
You must be signed in to change notification settings - Fork 684
add qnn eval CI #14528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qnn eval CI #14528
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14528
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 58 PendingAs of commit b582450 with merge base 7b33035 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
55f03ae
to
761d765
Compare
20f4c10
to
2280e1b
Compare
what is the motivation to add this PR? In general I agree with protecting code, but it is not clear what kind of breakage we expect to prevent with this and enabling this on every pull request seems expensive. |
It is super easy to use to evaluate accuracy with different modes and changes from qcom breaks it easily without tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed moving to trunk.yml if we cannot figure out how to make this specific job run only when changes are related to qualcomm
Will follow up on narrowing down the path for the job |
As title, add the script to prevent eval script regression. The test will calibrate qwen model and run eval, and test against threshold. If it's above the threshold, the test fail