Skip to content

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Sep 23, 2025

As title, add the script to prevent eval script regression. The test will calibrate qwen model and run eval, and test against threshold. If it's above the threshold, the test fail

image

Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14528

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 58 Pending

As of commit b582450 with merge base 7b33035 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
@cccclai cccclai marked this pull request as draft September 23, 2025 20:13
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai force-pushed the qnn_eval_ci branch 2 times, most recently from 55f03ae to 761d765 Compare September 23, 2025 20:31
@cccclai cccclai marked this pull request as ready for review September 24, 2025 17:57
@kimishpatel
Copy link
Contributor

what is the motivation to add this PR? In general I agree with protecting code, but it is not clear what kind of breakage we expect to prevent with this and enabling this on every pull request seems expensive.

@cccclai
Copy link
Contributor Author

cccclai commented Sep 25, 2025

pull

It is super easy to use to evaluate accuracy with different modes and changes from qcom breaks it easily without tests

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed moving to trunk.yml if we cannot figure out how to make this specific job run only when changes are related to qualcomm

@cccclai cccclai merged commit 3559c2a into main Sep 25, 2025
262 of 268 checks passed
@cccclai cccclai deleted the qnn_eval_ci branch September 25, 2025 18:16
@cccclai
Copy link
Contributor Author

cccclai commented Sep 25, 2025

Will follow up on narrowing down the path for the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants