Skip to content

Conversation

gggekov
Copy link
Collaborator

@gggekov gggekov commented Sep 24, 2025

The ResNet18 model uses a lot of ReLUs with inplace=True As a result of the correct annotation, we can pass the numerical accuracy check on resnet with lower atol.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Sep 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14540

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 2 Unrelated Failures

As of commit 75ac6b1 with merge base 25b3d63 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2025
@gggekov gggekov added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Sep 24, 2025
The ResNet18 model uses a lot of ReLUs with inplace=True
As a result of the correct annotation, we can pass the
numerical accuracy check on resnet with lower atol.

Change-Id: If629cf20df7bfeaa699c7ae8919c52f510cecb68
@gggekov gggekov force-pushed the fix_annotation_inplace_relu branch from fc3d9af to 75ac6b1 Compare September 25, 2025 12:57
use_to_edge_transform_and_lower=True,
per_channel_quantization=per_channel_quantization,
atol=0.5,
atol=0.25,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zingo zingo merged commit a747e4d into pytorch:main Sep 27, 2025
270 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants