Skip to content

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Sep 24, 2025

We had a few reverts last week's oncall.

Having these in place would have prevented them.

Test Plan:

unittest-buck CI job

Copy link

pytorch-bot bot commented Sep 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14542

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 5 Unrelated Failures

As of commit b1829c6 with merge base b3f3111 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin changed the title Shift Left: Build and test extension/llm packages whenever possible Shift Left: Build and test extension/llm/... buck packages packages whenever possible Sep 24, 2025
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83148558.

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83148558.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83148558.

…henever possible (#14542)

Summary:
We had a few reverts last week's oncall.

Having these in place would have prevented them.

Pull Request resolved: #14542

Test Plan: unittest-buck CI job

Reviewed By: kimishpatel

Differential Revision: D83148558

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83148558.

@mergennachin mergennachin merged commit f34efca into main Sep 25, 2025
271 of 285 checks passed
@mergennachin mergennachin deleted the run_buck_build_for_llm branch September 25, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants