Skip to content

Back out "Add extra logging in CoreML (#13890)" #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+0 −3
Merged

Back out "Add extra logging in CoreML (#13890)" #14568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backends/apple/coreml/runtime/delegate/ETCoreMLModelManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,14 +449,12 @@ - (nullable NSURL *)compiledModelURLWithIdentifier:(NSString *)identifier
case ModelAssetType::CompiledModel: {
// The model is already compiled; no further action needed.
// Return the existing model URL.
ETCoreMLLogInfo("The model in the pte file is pre-compiled. Skipping compilation.");
return modelURL;
}

case ModelAssetType::Model: {
// The model is not compiled yet.
// Compile the model at the specified URL with a maximum wait time of 5 minutes.
ETCoreMLLogInfo("The model in the pte file is not pre-compiled. Compiling with a 5 min timeout.");
NSURL *compiledModelURL = [ETCoreMLModelCompiler compileModelAtURL:modelURL
maxWaitTimeInSeconds:(5 * 60)
error:error];
Expand Down Expand Up @@ -492,7 +490,6 @@ - (nullable ETCoreMLAsset *)compiledModelAssetWithMetadata:(const ModelMetadata&
error:error];
if (compiledModelURL) {
// Move the compiled model to the asset manager to transfer ownership.
ETCoreMLLogInfo("Storing compiled asset with identifier=%@ in the asset manager.", identifier);
compiledModelAsset = [self.assetManager storeAssetAtURL:compiledModelURL withIdentifier:identifier error:error];
}
}];
Expand Down
Loading