Skip to content

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Sep 25, 2025

U55 does not support casting from int32 or any cast involving booleans. This patch introduces a new U55 operator check that will reject any such casts. Note that bool->bool and int32->int32 are considered ok as these will not result in any cast operation.

cc @digantdesai @freddan80 @per @zingo

U55 does not support casting from int32 or any cast involving booleans.
This patch introduces a new U55 operator check that will reject any such
casts. Note that bool->bool and int32->int32 are considered ok as these
will not result in any cast operation.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Ia0f81d02ab12f223ee630e27d9d15553434ad7e3
Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14577

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 4 Unrelated Failures

As of commit 2952c72 with merge base 25b3d63 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Sep 25, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 26, 2025

@digantdesai would this be OK to merge?

@digantdesai
Copy link
Contributor

Seems low risk for internal 🤞

@zingo zingo merged commit 6531b4a into pytorch:main Sep 26, 2025
268 of 277 checks passed
@zingo zingo added this to the 1.0.0 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants