-
Notifications
You must be signed in to change notification settings - Fork 685
NXP backend: Fix mean.dim
delegation and tests.
#14581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP backend: Fix mean.dim
delegation and tests.
#14581
Conversation
… node format. The pass `RemoveGetItemPass` replaces a `max_pool2d_with_indices` node with a `max_pool2d` node, that doesn't require a GetItem afterward. The new operator must, however, preserve the original node format. Therefore, a copy of the pass was created in `backends/nxp/_passes`, where it was modified. The new directory was created, because the pass doesn't follow the `NeutronEdgePass` interface.
Before, the format inference was done during conversion to NeutronIR (after partitioning), so the partitioner didn't yet know the formats. Now, the partitioner has the format data, which can be used to accurately select nodes for delegation.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14581
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 4 Unrelated FailuresAs of commit c5280bb with merge base b3f3111 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Only the last commit is relevant. Once another PR is merged, the commit will be re-based. |
This PR needs a
|
Summary
This PR updates the delegation condition for the
aten,mean,dim
operator to better reflect the requirements of Neutron.Test plan
Unit tests provided.