Arm backend: Small refactoring of aot_arm_compiler #14583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to have example models in the aot_arm_compiler script anymore, they are too simple, and there are other ways to do examples. Add and softmax can be replaced with example/models tests, add2 and add3 are deprecated. q-models can't be removed yet since the new testing is not in place but they should be as soon as it is. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I43ad1acaf46554245f6ed6928a79de653bc9b319
A start to simplify the aot_arm_compiler script. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: If6b956afbd2409ee244586aa60a77177915676cf
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14583
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Cancelled JobsAs of commit f24f4e4 with merge base 2283294 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
meta-cla
bot
added
the
CLA Signed
|
From what I can tell, failing checks are unrelated. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move evaluation logic out of aot_arm_compiler
Remove example models
It doesn't make sense to have example models in
the aot_arm_compiler script anymore, they are too
simple, and there are other ways to do examples.
Add and softmax can be replaced with example/models tests,
add2 and add3 are deprecated.
q-models can't be removed yet since the new testing is not
in place but they should be as soon as it is.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218