-
Notifications
You must be signed in to change notification settings - Fork 684
Add strict-flag to ExportSession #14588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14588
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c06c386 with merge base 3b16bc1 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to be a general problem for all "non-partitioner" op-lib backends. My thinking is we should either hide them behind a pseudo-partitioner wrapper to make it more composible. For now this might be OK. See some comments I added here. Stamping to unblock. Let's try to resolve the comments before merging.
e85332c
to
8df6a1a
Compare
Ack, I removed the post_edge commit from this PR and will create a new with the post-to-backend stage. |
Default is True, mirroring earlier behavior. Also update ExportSession to handle this. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Iaa47fabb713daf9d5c352408bb20625d05b7e476
8df6a1a
to
c06c386
Compare
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218