Skip to content

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Sep 25, 2025

**Add strict export option to ExportRecipe**

Default is True, mirroring earlier behavior.
Also update ExportSession to handle this.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14588

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c06c386 with merge base 3b16bc1 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 25, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to be a general problem for all "non-partitioner" op-lib backends. My thinking is we should either hide them behind a pseudo-partitioner wrapper to make it more composible. For now this might be OK. See some comments I added here. Stamping to unblock. Let's try to resolve the comments before merging.

@Erik-Lundell Erik-Lundell changed the title Add strict-flag and post-edge passes to ExportSession Add strict-flag to ExportSession Oct 6, 2025
@Erik-Lundell
Copy link
Collaborator Author

Ack, I removed the post_edge commit from this PR and will create a new with the post-to-backend stage.

Default is True, mirroring earlier behavior.
Also update ExportSession to handle this.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: Iaa47fabb713daf9d5c352408bb20625d05b7e476
@zingo zingo merged commit f81e834 into pytorch:main Oct 6, 2025
128 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants