Skip to content

Android use new glslc #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

Android use new glslc #14596

merged 3 commits into from
Sep 25, 2025

Conversation

kirklandsign
Copy link
Contributor

Run workflow

SS-JIA and others added 2 commits September 25, 2025 10:44
@SS-JIA
[ET-VK][ez] Do not allow using glslc from Android NDK
e95646a 
Summary:
Title says it all. The `glslc` binary distributed with the Android NDK can no longer be used to build the Vulkan delegate since it doesn't support the GL_EXT_integer_dot_product extension.

This PR updates the CMakeLists.txt to look for the `glslc` installed on the system instead by default.
@kirklandsign
Android use new glslc
637a8ce
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14596

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 7 Pending, 2 Unrelated Failures

As of commit deb59e4 with merge base dc87d22 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review September 25, 2025 16:19
@kirklandsign kirklandsign merged commit ebabf52 into main Sep 25, 2025
126 of 133 checks passed
@kirklandsign kirklandsign deleted the vulkan-glslc-update branch September 25, 2025 17:09
@kirklandsign
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Sep 25, 2025
@kirklandsign @SS-JIA @pytorchbot
Android use new glslc (#14596)
83f3bab 
Validated by workflow https://github.com/pytorch/executorch/actions/runs/18013292360
Currently download SDK each time when we build vulkan AAR.

Co-authored-by: Stephen Jia <ssjia@meta.com>
(cherry picked from commit ebabf52)
@pytorchbot
Copy link
Collaborator

Cherry picking #14596

The cherry pick PR is at #14600 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 25, 2025
Open
@SS-JIA SS-JIA mentioned this pull request Sep 25, 2025
Closed
kirklandsign added a commit that referenced this pull request Sep 25, 2025
@kirklandsign @SS-JIA
Android use new glslc (#14596)
a1a3dbe 
Validated by workflow https://github.com/pytorch/executorch/actions/runs/18013292360
Currently download SDK each time when we build vulkan AAR.

Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @pytorchbot @SS-JIA