Skip to content

Conversation

roman-janik-nxp
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp commented Sep 25, 2025

Summary

This PR refactors and extends tests for Addmm and Mm converters. Adds quantization for Mm operator.

Test plan

Unit tests provided.

cc @digantdesai @JakeStevens @robert-kalmar

Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14601

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 88f6c22 with merge base ce6e2cf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@roman-janik-nxp
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Sep 25, 2025
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-541-Extend-tests-for-Linear-Addmm-Mm-converters-add-Mm-quantization_github branch from 795ab37 to ee4586d Compare September 29, 2025 18:43
@roman-janik-nxp
Copy link
Collaborator Author

There are failing tests for Mm converter in unittest-nxp-neutron, due to unforeseen dependency on Neutron converter 25.09 regarding handling bias tensors. The PR for upgrade to NC 25.09 is already created #14591, so these tests should pass once there is new NC version. For now on hold.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-541-Extend-tests-for-Linear-Addmm-Mm-converters-add-Mm-quantization_github branch from ee4586d to 88f6c22 Compare October 1, 2025 09:59
@roman-janik-nxp
Copy link
Collaborator Author

Failing workflows are unrelated to this PR, ready for merge.

@roman-janik-nxp roman-janik-nxp merged commit ffd27ca into pytorch:main Oct 1, 2025
127 of 130 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-541-Extend-tests-for-Linear-Addmm-Mm-converters-add-Mm-quantization_github branch October 1, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants