Skip to content

Conversation

agrima1304
Copy link
Collaborator

@agrima1304 agrima1304 commented Sep 26, 2025

Stack is not in the list of core ATen ops and is decomposed automatically when lowering the graph (https://docs.pytorch.org/docs/main/export.html#export-ir-decompositions), so only the tests need to be added.

stack is in this decomp table: https://github.com/pytorch/pytorch/blob/5d749ceb92c2c28bcfbdf918b4ab99b1a91fcb50/torch/_decomp/__init__.py#L466

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Sep 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14623

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d9f9aab with merge base f24351a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2025
@agrima1304
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 26, 2025
@agrima1304
Copy link
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Sep 26, 2025
@agrima1304
Copy link
Collaborator Author

@pytorchbot label "ciflow/trunk"

Copy link

pytorch-bot bot commented Sep 26, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Signed-off-by: Agrima Khare <agrima.khare@arm.com>
Change-Id: I001fc666c69d7735e1a5f0502bfaed6104a8d3c5
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Welcome to ET.

@zingo
Copy link
Collaborator

zingo commented Oct 1, 2025

@agrima1304 there is a fail in an Arm test, it might be a flaky test and a re-run might help, if so and it turns green we can merge and ask in about it in our internal slack nd maybe create a ticket. Let me know if you dont know how to re-run the test and Ill show you.

@zingo zingo merged commit 0145604 into pytorch:main Oct 2, 2025
214 of 217 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants