-
Notifications
You must be signed in to change notification settings - Fork 685
Arm Backend: Add tests for stack.default #14623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14623
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d9f9aab with merge base f24351a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "partner: arm" |
@pytorchbot label "release notes: arm" |
@pytorchbot label "ciflow/trunk" |
To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Signed-off-by: Agrima Khare <agrima.khare@arm.com> Change-Id: I001fc666c69d7735e1a5f0502bfaed6104a8d3c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Welcome to ET.
@agrima1304 there is a fail in an Arm test, it might be a flaky test and a re-run might help, if so and it turns green we can merge and ask in about it in our internal slack nd maybe create a ticket. Let me know if you dont know how to re-run the test and Ill show you. |
Stack is not in the list of core ATen ops and is decomposed automatically when lowering the graph (https://docs.pytorch.org/docs/main/export.html#export-ir-decompositions), so only the tests need to be added.
stack is in this decomp table: https://github.com/pytorch/pytorch/blob/5d749ceb92c2c28bcfbdf918b4ab99b1a91fcb50/torch/_decomp/__init__.py#L466
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218