Skip to content

Conversation

mansnils
Copy link
Collaborator

@mansnils mansnils commented Sep 26, 2025

Deep-copying the input avoids it getting mutated by the first reference run.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Deep-copying the input avoids it getting mutated by the first
reference run.

Change-Id: Ie0309528e9b795f6e628eb01531b14339fb66f81
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Sep 26, 2025
Copy link

pytorch-bot bot commented Sep 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14625

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 5d88fa3 with merge base 4622edb (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2025
for run_iteration in range(num_runs):
reference_input = inputs if inputs else next(self.generate_random_inputs())

# Avoid issues with inplace operators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I am sure we will run this in other places, but I see just Silu, which is good. :)

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zingo zingo merged commit b6bc421 into pytorch:main Oct 6, 2025
278 of 284 checks passed
@mansnils
Copy link
Collaborator Author

mansnils commented Oct 7, 2025

@pytorchbot cherry-pick --onto release/1.0 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 7, 2025
Deep-copying the input avoids it getting mutated by the first reference
run.

(cherry picked from commit b6bc421)
@pytorchbot
Copy link
Collaborator

Cherry picking #14625

The cherry pick PR is at #14855 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants