-
Notifications
You must be signed in to change notification settings - Fork 684
Arm backend: Fix Arm tester issue for inplace ops #14625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deep-copying the input avoids it getting mutated by the first reference run. Change-Id: Ie0309528e9b795f6e628eb01531b14339fb66f81
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14625
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 5d88fa3 with merge base 4622edb ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
for run_iteration in range(num_runs): | ||
reference_input = inputs if inputs else next(self.generate_random_inputs()) | ||
|
||
# Avoid issues with inplace operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I am sure we will run this in other places, but I see just Silu, which is good. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@pytorchbot cherry-pick --onto release/1.0 -c fixnewfeature |
Deep-copying the input avoids it getting mutated by the first reference run. (cherry picked from commit b6bc421)
Cherry picking #14625The cherry pick PR is at #14855 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Deep-copying the input avoids it getting mutated by the first reference run.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218