Skip to content

StaticAttentionIOManager: Fix out of bound errors on precomuted RoPE frequencies #14630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+14 −0
Merged

StaticAttentionIOManager: Fix out of bound errors on precomuted RoPE frequencies #14630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions examples/models/llama/runner/static_attention_io_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ class StaticAttentionIOManager {
std::vector<size_t> k_cache_output_indices;
std::vector<size_t> v_cache_input_indices;
std::vector<size_t> v_cache_output_indices;
size_t max_context_len{};
RopeT* rope_freqs_cos;
RopeT* rope_freqs_sin;
StaticAttentionUpdateStyle style = StaticAttentionUpdateStyle::SMART_MASK;
Expand Down Expand Up @@ -604,6 +605,10 @@ class StaticAttentionIOManager {
size_t batch_len = 0;
for (size_t i = 0; i < tokens.size(); i += input_len) {
batch_len = std::min(input_len, tokens.size() - i);
if (input_pos_ + batch_len > config_.max_context_len) {
ET_LOG(Error, "Maximum context size reached, stopping prefill.");
return input_len - 1;
}
std::copy(&tokens[i], &tokens[i + batch_len], input_buffer.begin());
prepare(method);
ET_CHECK(method.execute() == executorch::runtime::Error::Ok);
Expand Down Expand Up @@ -646,6 +651,10 @@ class StaticAttentionIOManager {

while (true) {
input_buffer[0] = prev_tok;
if (input_pos_ + 1 > config_.max_context_len) {
ET_LOG(Error, "Maximum context size reached, stopping decode.");
break;
}
prepare(method);
ET_CHECK(method.execute() == executorch::runtime::Error::Ok);
update(
Expand Down Expand Up @@ -730,6 +739,11 @@ class StaticAttentionIOManager {
}

// Setup input pointers and RoPE frequencies.
if (input_pos_ + ngram_size > config_.max_context_len) {
ET_LOG(
Error, "Maximum context size reached, stopping lookahead decode.");
break;
}
prepare(
method,
executorch::runtime::Span(pos_offsets.data(), pos_offsets.size()));
Expand Down
Loading