Skip to content

Mark remaining clases final in ObjC bindings. #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

Mark remaining clases final in ObjC bindings. #14641

merged 2 commits into from
Sep 29, 2025

Conversation

pytorchbot
Copy link
Collaborator

Summary: .

Differential Revision: D83382356

@shoumikhin @pytorchbot
Mark remaining clases final in ObjC bindings.
42902e1 
Differential Revision: D83382356

Pull Request resolved: #14634

(cherry picked from commit 73dc30b)
@pytorchbot pytorchbot mentioned this pull request Sep 26, 2025
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14641

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 3 Pending

As of commit 5d8da96 with merge base e0dda90 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot pytorchbot mentioned this pull request Sep 26, 2025
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2025
@GregoryComer
Copy link
Member

Rebasing to re-test after mac job fix.

@GregoryComer GregoryComer merged commit 7889f10 into release/1.0 Sep 29, 2025
122 of 129 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14634-by-pytorch_bot_bot_ branch September 29, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @GregoryComer @shoumikhin