Rescale add int16 correctly #14645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zingo merged 1 commit into main from export-D82906134

Sep 30, 2025

+73 −15

Contributor

3l1 commented Sep 28, 2025

Differential Revision: D82906134

3l1 requested a review from digantdesai as a code owner

September 28, 2025 17:35

pytorch-bot bot commented Sep 28, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14645

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit b502ed5 with merge base 181ed4d ():

NEW FAILURE - The following job has failed:

trunk / test-multimodal-macos (gemma3-4b) / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 139

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / test-setup-linux-gcc / linux-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 28, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

facebook-github-bot added fb-exported meta-exported labels

Contributor Author

3l1 commented Sep 28, 2025

@pytorchbot label "release notes: none"

pytorch-bot bot added the release notes: none label

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

d263d2f

Summary: Pull Request resolved: #14645

Differential Revision: D82906134

facebook-github-bot force-pushed the export-D82906134 branch from b564bd0 to d263d2f Compare

September 28, 2025 18:06

Contributor

facebook-github-bot commented Sep 28, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

3l1 force-pushed the export-D82906134 branch from d263d2f to c3c2808 Compare

September 28, 2025 18:06

3l1 added a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

c3c2808

Summary: Pull Request resolved: #14645

Differential Revision: D82906134

Contributor

facebook-github-bot commented Sep 28, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

38e0888

Summary: Pull Request resolved: #14645

Differential Revision: D82906134

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

f2aa09c

Summary: Pull Request resolved: #14645

Differential Revision: D82906134

facebook-github-bot force-pushed the export-D82906134 branch from c3c2808 to f2aa09c Compare

September 28, 2025 18:23

Contributor

facebook-github-bot commented Sep 28, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

3l1 added a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

58570e4

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Differential Revision: D82906134

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

852e884

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Differential Revision: D82906134

digantdesai approved these changes

View reviewed changes

Contributor

digantdesai left a comment

Review automatically exported from Phabricator review in Meta.

3l1 requested review from per and gggekov

September 29, 2025 15:50

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

4ba230c

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Reviewed By: digantdesai

Differential Revision: D82906134

facebook-github-bot force-pushed the export-D82906134 branch from f2aa09c to 4ba230c Compare

September 29, 2025 15:55

Contributor

facebook-github-bot commented Sep 29, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

b4c7b78

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Reviewed By: digantdesai

Differential Revision: D82906134

3l1 added a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

bc89399

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Reviewed By: digantdesai

Differential Revision: D82906134

facebook-github-bot pushed a commit that referenced this pull request


          Rescale add int16 correctly (#14645)

b7c44d6

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor

Reviewed By: digantdesai

Differential Revision: D82906134


          Rescale add int16 correctly (#14645)

b502ed5

Summary:



 we rescale to int32 using a different common scale(2*max(left scale,right scale))

the resccale(s) -> add[int32] -> rescale from TOSA is converted to a single add command stream instruction by Vela/Regor


bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: digantdesai, Ninja91

Differential Revision: D82906134

facebook-github-bot force-pushed the export-D82906134 branch from 4ba230c to b502ed5 Compare

September 30, 2025 03:04

Contributor

facebook-github-bot commented Sep 30, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82906134.

per added the ciflow/trunk label

per approved these changes

View reviewed changes

zingo merged commit f7c009e into main

286 of 289 checks passed

zingo deleted the export-D82906134 branch

September 30, 2025 10:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed fb-exported meta-exported release notes: none