Rescale sub int16 correctly #14650
Merged
Rescale sub int16 correctly #14650
+118
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14650
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 919c918 with merge base 41379fb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
digantdesai
approved these changes
Sep 29, 2025
digantdesai
reviewed
Sep 29, 2025
| def insert_rescale_ops_int16_to_int32_maxscale( | ||
| tosa_graph: Any, inputs: list[TosaArg], node: Node, tosa_spec=None | ||
| ) -> tuple[list[Any], float]: | ||
| """For ADD and SUB with int16 inputs, we rescale to int32 using a different common scale(2*max(left scale,right scale)) |
digantdesai
approved these changes
Sep 29, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Summary: we rescale to int32 using a different common scale(2*max(left scale,right scale)) the rescale(s) -> sub[int32] -> rescale from TOSA is converted to a single sub command stream instruction by Vela/Regor Reviewed By: digantdesai Differential Revision: D83437623
facebook-github-bot
force-pushed
the
export-D83437623
branch
from
822b630 to
69ae265
Compare
3l1
added a commit
that referenced
this pull request
Sep 29, 2025
Summary: we rescale to int32 using a different common scale(2*max(left scale,right scale)) the rescale(s) -> sub[int32] -> rescale from TOSA is converted to a single sub command stream instruction by Vela/Regor Reviewed By: digantdesai Differential Revision: D83437623
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Summary: we rescale to int32 using a different common scale(2*max(left scale,right scale)) the rescale(s) -> sub[int32] -> rescale from TOSA is converted to a single sub command stream instruction by Vela/Regor Reviewed By: digantdesai Differential Revision: D83437623
Summary: we rescale to int32 using a different common scale(2*max(left scale,right scale)) the rescale(s) -> sub[int32] -> rescale from TOSA is converted to a single sub command stream instruction by Vela/Regor bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: digantdesai Differential Revision: D83437623
facebook-github-bot
force-pushed
the
export-D83437623
branch
from
69ae265 to
919c918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
we rescale to int32 using a different common scale(2*max(left scale,right scale))
the rescale(s) -> sub[int32] -> rescale from TOSA is converted to a single sub command stream instruction by Vela/Regor
Differential Revision: D83437623