-
Notifications
You must be signed in to change notification settings - Fork 686
Arm backend: Backend test TOSA FP, INT and Ethos-U55/U85 #14653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Backend test TOSA FP, INT and Ethos-U55/U85 #14653
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14653
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 45 PendingAs of commit 71b3a6e with merge base 0cd8256 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Split the arm_tosa test job that tested TOSA-1.0+FP into arm_tosa_fp and arm_tosa_int to also test TOSA-1.0+INT Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I4a265e5fed84f1f3fa4a0088ec797c09cc416ee6
Create arm_ethos_u55 and arm_ethos_u85 test flows and add them to CI Build a semihosted runner for testing on the Corstone3x0 FVP Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: Icbbbf8a5e796071482a8ad0de290fbaef61e0b04
ee236a1
to
7ff0cb7
Compare
backend="arm", | ||
tester_factory=_create_arm_tester_tosa_fp, | ||
tester_factory=_create_arm_tester, | ||
supports_serialize=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not enable this? This should work if we can provide a runner somehow to the FVP? This might be an alternative to pybinding assuming we want to do it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We hope to enable more and more here over time. Plan is to do more in later PR but would be nice to get som INT stuff into the flow already now 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for supports_serialize=False, specificalli, we have not looked deep enough yet to check it, its basicaly just left as is from the first PR by @GregoryComer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me. FYI I did migrate the test suite to use pytest (#14456), though this shouldn't affect your PR much, if at all.
This is an evolving effort, so feel free to make suggestions if the test harness or logic isn't working for your use case or if you have suggestions for improvements.
Spotted the pytest that worked out great. |
Summary
Create arm_ethos_u55 and arm_ethos_u85 test flows and add them to CI
Build a semihosted runner for testing on the Corstone3x0 FVP
And split the arm_tosa test job that tested TOSA-1.0+FP into arm_tosa_fp and arm_tosa_int to also test TOSA-1.0+INT
Test plan
This will add new tests for arm_tosa_int arm_ethos_u55 and arm_ethos_u85
cc @digantdesai @freddan80 @per @oscarandersson8218