Skip to content

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Sep 29, 2025

Summary

Create arm_ethos_u55 and arm_ethos_u85 test flows and add them to CI
Build a semihosted runner for testing on the Corstone3x0 FVP
And split the arm_tosa test job that tested TOSA-1.0+FP into arm_tosa_fp and arm_tosa_int to also test TOSA-1.0+INT

Test plan

This will add new tests for arm_tosa_int arm_ethos_u55 and arm_ethos_u85

cc @digantdesai @freddan80 @per @oscarandersson8218

@zingo zingo requested a review from cccclai as a code owner September 29, 2025 09:20
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Sep 29, 2025
Copy link

pytorch-bot bot commented Sep 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14653

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 45 Pending

As of commit 71b3a6e with merge base 0cd8256 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2025
@zingo zingo requested review from GregoryComer and cccclai and removed request for cccclai September 29, 2025 09:20
Split the arm_tosa test job that tested TOSA-1.0+FP into arm_tosa_fp
and arm_tosa_int to also test TOSA-1.0+INT

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: I4a265e5fed84f1f3fa4a0088ec797c09cc416ee6
Create arm_ethos_u55 and arm_ethos_u85 test flows and add them to CI
Build a semihosted runner for testing on the Corstone3x0 FVP

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: Icbbbf8a5e796071482a8ad0de290fbaef61e0b04
@zingo zingo force-pushed the Arm-backend-Backend-test-both-TOSA-FP-and-TOSA-INT branch from ee236a1 to 7ff0cb7 Compare September 30, 2025 12:46
@zingo zingo changed the title Arm backend: Backend test both TOSA FP and TOSA INT Arm backend: Backend test TOSA FP, INT and Ethos-U55/U85 Sep 30, 2025
backend="arm",
tester_factory=_create_arm_tester_tosa_fp,
tester_factory=_create_arm_tester,
supports_serialize=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not enable this? This should work if we can provide a runner somehow to the FVP? This might be an alternative to pybinding assuming we want to do it this way.

Copy link
Collaborator Author

@zingo zingo Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hope to enable more and more here over time. Plan is to do more in later PR but would be nice to get som INT stuff into the flow already now 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for supports_serialize=False, specificalli, we have not looked deep enough yet to check it, its basicaly just left as is from the first PR by @GregoryComer

Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. FYI I did migrate the test suite to use pytest (#14456), though this shouldn't affect your PR much, if at all.

This is an evolving effort, so feel free to make suggestions if the test harness or logic isn't working for your use case or if you have suggestions for improvements.

@zingo
Copy link
Collaborator Author

zingo commented Oct 1, 2025

Spotted the pytest that worked out great.
I have a quant change for EthosU on testing. Thanks for starting this framework. It makes sense to sycronize backend test.

@zingo zingo merged commit 426b701 into pytorch:main Oct 1, 2025
271 of 272 checks passed
@zingo zingo deleted the Arm-backend-Backend-test-both-TOSA-FP-and-TOSA-INT branch October 3, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants