Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary:
Previously we deduplicated entire 'BackendDelegate' blobs using the preprocessed blob. If two BackendDelegate fields have different id or compile specs, it would be disregarded.

This diff:

  1. Only deduplicates the preprocessed blob. BackendDelegate retains its own compile specs, etc.
  2. Removes the per-method 'delegate_cache', as we have a program-wide delegate cache.
  3. Adds a test to confirm we have one delegate segment but two BackendDelegate references pointing at it.

Differential Revision: D83162107

Differential Revision: D83162107

Pull Request resolved: #14564

(cherry picked from commit fd5f946)
Copy link

pytorch-bot bot commented Sep 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14658

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs

As of commit 7473e17 with merge base e0dda90 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2025
@GregoryComer
Copy link
Member

Rebasing to re-test after mac job fix.

@GregoryComer GregoryComer merged commit 00fe3ac into release/1.0 Oct 1, 2025
119 of 122 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14564-by-pytorch_bot_bot_ branch October 1, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants