Skip to content

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Sep 30, 2025

Stack from ghstack (oldest at bottom):

Summary:

Introduced aoti_torch__reinterpret_tensor, which creates a new tensor view that reinterprets the same underlying memory with custom shape and strides.

Reviewed By:

Differential Revision:

Summary:

This diff introduce `aoti_torch_delete_tensor_object` for deleting tensors created during cuda backend inference.

Reviewed By:

[ghstack-poisoned]
Summary:

This function introduce aoti_torch_create_tensor_from_blob_v2, a function that create tensor from data blob and custom stride and size.

Worth to notice that unlike aoti_torch_empty_strided, the tensor created by aoti_torch_create_tensor_from_blob_v2 will not have the control of the memory blob. Therefore when we delete it, the memory will not be freed.

Reviewed By:

Differential Revision:

[ghstack-poisoned]
Summary:

Introduced aoti_torch__reinterpret_tensor, which creates a new tensor view that reinterprets the same underlying memory with custom shape and strides.

Reviewed By:

Differential Revision:

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14688

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 27 Pending, 1 Unrelated Failure

As of commit b4adeda with merge base 44972ad (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2025
larryliu0820 added a commit that referenced this pull request Sep 30, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #14690
* #14689
* #14688
* #14687
* __->__ #14686

Summary:

This diff introduce `aoti_torch_delete_tensor_object` for deleting
tensors created during cuda backend inference.

Reviewed By:
larryliu0820 added a commit that referenced this pull request Sep 30, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #14690
* #14689
* #14688
* __->__ #14687
* #14686

Summary:

This function introduce aoti_torch_create_tensor_from_blob_v2, a
function that create tensor from data blob and custom stride and size.

Worth to notice that unlike aoti_torch_empty_strided, the tensor created
by aoti_torch_create_tensor_from_blob_v2 will not have the control of
the memory blob. Therefore when we delete it, the memory will not be
freed.

Reviewed By:

Differential Revision:
larryliu0820 added a commit that referenced this pull request Sep 30, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #14690
* #14689
* #14688
* __->__ #14700
* #14686

Summary:
This is a manual cherry pick of #14687 

This function introduce aoti_torch_create_tensor_from_blob_v2, a
function that create tensor from data blob and custom stride and size.

Worth to notice that unlike aoti_torch_empty_strided, the tensor created
by aoti_torch_create_tensor_from_blob_v2 will not have the control of
the memory blob. Therefore when we delete it, the memory will not be
freed.

Reviewed By:

Differential Revision:
@larryliu0820 larryliu0820 changed the base branch from gh/larryliu0820/78/base to main September 30, 2025 19:34
@larryliu0820 larryliu0820 added the release notes: desktop for desktop/laptop workstream label Sep 30, 2025
@larryliu0820 larryliu0820 merged commit 696bf19 into main Sep 30, 2025
127 of 129 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/78/head branch September 30, 2025 21:06
larryliu0820 added a commit that referenced this pull request Sep 30, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #14690
* __->__ #14689
* #14688
* #14687
* #14686

Summary:

This diff introduce `aoti_torch_copy_`, the function for copying tensor
inside cuda backend.

Right now it only support copy between tensors with same dtype.

Reviewed By:

Differential Revision:
larryliu0820 added a commit that referenced this pull request Sep 30, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ #14690
* #14689
* #14688
* #14687
* #14686

Summary:

this is a comprehensive update to use ET_CHECK macro to replace original
if..else check for better follow et's law

Reviewed By:

Differential Revision:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: desktop for desktop/laptop workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants