Skip to content

Update addmm int16 for Ethos-U85 #14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Update addmm int16 for Ethos-U85 #14714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions backends/arm/operators/op_bmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ def define_node(
input1_zp = input_qparams[1].get_zp_per_tensor()
bmm_result = tosa_graph.addIntermediate(output.shape, ts.DType.INT32)
bmm_output_name = bmm_result.name
elif inputs[0].dtype == ts.DType.INT16:
input_qparams = get_input_qparams(node)
input0_zp = input_qparams[0].get_zp_per_tensor()
input1_zp = input_qparams[1].get_zp_per_tensor()
bmm_result = tosa_graph.addIntermediate(output.shape, ts.DType.INT48)
bmm_output_name = bmm_result.name
else:
bmm_output_name = output.name
input0_zp, input1_zp = 0, 0
Expand Down Expand Up @@ -118,3 +124,20 @@ def define_node(
output_zp=[output_qparams.get_zp_per_tensor()],
rounding_mode=RoundingMode.SINGLE_ROUND,
)
elif output.dtype == ts.DType.INT16:
output_qparams = get_output_qparams(node)[0]
final_output_scale = (
input_qparams[0].get_scale_per_tensor() * input_qparams[1].get_scale_per_tensor() # type: ignore[possibly-undefined] # pyre-ignore[61]
) / output_qparams.get_scale_per_tensor()

build_rescale(
tosa_fb=tosa_graph,
scale=[final_output_scale],
# pyre-ignore[61]: Uninitialized local [61]: Local variable `bmm_result` is undefined, or not always defined.
input_node=bmm_result, # type: ignore[possibly-undefined]
output_name=output.name,
output_type=ts.DType.INT16,
input_zp=[0],
output_zp=[output_qparams.get_zp_per_tensor()],
rounding_mode=RoundingMode.SINGLE_ROUND,
)
6 changes: 0 additions & 6 deletions backends/arm/test/ops/test_addmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,6 @@ def get_symmetric_a16w8_addmm_quantizer(per_channel_quantization=False):


@common.parametrize("test_data", test_data_suite)
@pytest.mark.xfail(
reason="missing int16 addmm ops support; fails at TOSA reference model with Unsupported operation type or rank. See: https://github.com/pytorch/executorch/issues/13979"
)
def test_addmm_16a8w_tosa_INT(test_data: input_t1):
"""Test addmm (FC layer) operation with 16A8W quantization (16-bit activations, 8-bit weights)"""
per_channel_quantization = False
Expand Down Expand Up @@ -268,9 +265,6 @@ def test_addmm_16a8w_u55_INT16(test_data: input_t1):

@common.parametrize("test_data", test_data_suite)
@common.XfailIfNoCorstone320
@pytest.mark.xfail(
reason="Vela compilation fails with 'Invalid arguments' for int16 addmm operations"
)
def test_addmm_16a8w_u85_INT16(test_data: input_t1):
"""Test addmm (FC layer) operation with 16A8W quantization on U85 (16-bit activations, 8-bit weights)"""
per_channel_quantization = False
Expand Down
Loading