-
Notifications
You must be signed in to change notification settings - Fork 683
Restructure ET documentation with 'Platform First' model #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14720
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 18 PendingAs of commit 7743abb with merge base d4d24ec ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline, thanks @psiddh for doing this
docs/source/index.md
Outdated
### Documentation Navigation | ||
#### Introduction | ||
|
||
#### Getting Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this is called "Getting Started"
Can we change to something like "Background", "Introduction", "Design and Architecture"?
docs/source/index.md
Outdated
- [Troubleshooting](using-executorch-troubleshooting) | ||
- [Architecture & Components](getting-started-architecture) | ||
- [Core Concepts](concepts) | ||
- [Building from Source](using-executorch-building-from-source) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a section called
"Quick Start" that contains only a few sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/source/index.md
Outdated
#### Fundamentals | ||
- [Model Export & Lowering](using-executorch-export) | ||
- [Runtime Architecture](runtime-overview) | ||
- [Memory Management](compiler-memory-planning) | ||
- [Performance Concepts](runtime-profiling) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit out of place. I'd say dissolve this section
- I'd say move "Model Export & Lowering" to "Quick Start"
- Runtime Architecture to the top section called (either "Background", "Introduction", "Design and Architecture").
- Memory management and profiling can be in be either in Runtime or Advanced Topics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree abt this section! The last two are already part of Advanced Topics, Removed this section completely
docs/source/index.md
Outdated
- [CoreML (NPU/GPU - recommended)](backends-coreml) | ||
- [MPS (GPU)](backends-mps) | ||
- [XNNPACK (CPU)](backends-xnnpack) | ||
- [Vulkan (GPU)](backends-vulkan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Vulkan available on iOS??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy - paste error, removed
docs/source/index.md
Outdated
- [XNNPACK (CPU)](backends-xnnpack) | ||
- [Vulkan (GPU)](backends-vulkan) | ||
``` | ||
- [Working with LLMs - iOS Examples](https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to LLM, not mv3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/source/index.md
Outdated
- [C++ Runtime Integration](using-executorch-cpp) | ||
- **Microcontrollers** | ||
- [Cadence Xtensa Backend](backends-cadence) | ||
- [ARM Ethos-U NPU Backend](backends-arm-ethos-u) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also Include this tutorial somewhere tutorial-arm-ethos-u.html https://docs.pytorch.org/executorch/1.0/tutorial-arm-ethos-u.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On clicking backends-arm-ethos-u --> User would be able to discover [Arm Ethos-U Backend Tutorial]
(or) are you suggesting that Arm Ethos-U Backend Tutorial should be surfaced at the top
docs/source/index.md
Outdated
- [Qualcomm AI Engine (NPU)](backends-qualcomm) | ||
- [MediaTek (NPU)](backends-mediatek) | ||
- [Samsung Exynos (NPU)](backends-samsung-exynos) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include Arm VGF
https://docs.pytorch.org/executorch/1.0/backends-arm-vgf.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where shall we include https://docs.pytorch.org/executorch/1.0/tutorial-arm-vgf.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added - ARM VGF Backend
On clicking this top link, it should take users to next page where [tutorial-arm-vgf.html] will be discovered.
Would this work ?
docs/source/android-section.md
Outdated
# Android | ||
|
||
## Quick Start & Integration | ||
[Getting started with ExecuTorch on Android](using-executorch-android) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on it from here
https://docs-preview.pytorch.org/pytorch/executorch/14720/android-section.html
the left navigation disappears
https://docs-preview.pytorch.org/pytorch/executorch/14720/using-executorch-android.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to look into it further.
|
||
### Documentation Navigation | ||
#### Introduction | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to list out all items individually?
How about we just list top-level categories?
I know that it predates you... I really don't like that we have a documentation sitemap on this page to begin with, we used to have something else before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, top categories seems like a better as opposed to maintaining yet another site-map there with individual pages.
docs/source/android-section.md
Outdated
## Available Backends | ||
|
||
### CPU Backends | ||
- [XNNPACK Backend](backends-xnnpack) - Optimized CPU inference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on this https://docs-preview.pytorch.org/pytorch/executorch/14720/backends-xnnpack.html it goes to iOS section.
Hi @psiddh I am walking through the website via this link preview https://doc-previews.s3.us-east-1.amazonaws.com/pytorch/executorch/14720/index.html (the link commented by the bot was old -- so I looked at the log of "build (buck2) / Build doc" and found this link)
|
By the way, "https://docs-preview.pytorch.org/pytorch/executorch/14720/index.html" was still showing old cached result Here's the trick I found Ad ?v=1 (or anything), which forces to fetch new content https://docs-preview.pytorch.org/pytorch/executorch/14720/index.html?v=1 |
Follow these guides in order to get started with ExecuTorch: | ||
|
||
- **1. {doc}`getting-started`** - Initial Setup: Set up your development environment and run your first ExecuTorch example. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this page? https://docs.pytorch.org/executorch/stable/using-executorch-export.html
docs/source/quick-start-section.md
Outdated
|
||
## Prerequisites | ||
|
||
- Python 3.8+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's 3.10-3.12
docs/source/quick-start-section.md
Outdated
## Prerequisites | ||
|
||
- Python 3.8+ | ||
- PyTorch 2.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyTorch 2.9+ (it installs as depedency, so probably no need to explicitly mention). Otherwise, we have to book keep everytime
docs/source/platforms-desktop.md
Outdated
- [CoreML (recommended)](backends-coreml) | ||
- [MPS (Apple Silicon)](backends-mps) | ||
- [XNNPACK (CPU)](backends-xnnpack) | ||
- [Vulkan (GPU)](backends-vulkan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it available natively on MacOS
@@ -0,0 +1,19 @@ | |||
(desktop-section)= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merging this landing page (desktop-section) and (platforms-desktop.md) page?
@@ -0,0 +1,20 @@ | |||
(embedded-section)= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this page embedded-section.md and platforms-embedded.md pages
### Microcontrollers | ||
- [Cadence Xtensa Backend](backends-cadence) | ||
- [ARM Ethos-U NPU Backend](backends-arm-ethos-u) | ||
- [Custom Backend Development](backend-delegates-integration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have this section?
docs/source/embedded-backends.md
Outdated
embedded-cadence | ||
embedded-arm-ethos-u | ||
embedded-nxp | ||
backend-delegates-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend-delegates-integration in embedded doesn't make sense. bring to "Backend Overview" section
Thank you @psiddh Looks great |
docs/source/index.md
Outdated
**🚀 Story 2** | ||
*One line for Story 2* | ||
|
||
[Click to read the complete details →](https://engineering.fb.com/2024/01/executorch-llama-mobile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create a standalone landing page, so that I can start populating?
We can still keep the Story 1, Story 2 etc
b7a03d0
to
117d2db
Compare
docs/source/backends-overview.md
Outdated
|
||
## Learn More | ||
|
||
- [XNNPACK (Mobile CPU)](backends-xnnpack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [XNNPACK (Mobile CPU)](backends-xnnpack) | |
- [XNNPACK (CPU)](backends-xnnpack) |
docs/source/backends-overview.md
Outdated
|
||
## Learn More | ||
|
||
- [XNNPACK (Mobile CPU)](backends-xnnpack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embed the links in the table?
docs/source/backends-overview.md
Outdated
| XNNPACK | All | CPU | General-purpose, fallback | | ||
| Core ML | iOS, macOS | NPU/GPU | Apple devices, high performance | | ||
| Metal Performance Shaders (MPS) | iOS, macOS | GPU | Apple GPU acceleration | | ||
| Vulkan | Android | GPU | Android GPU acceleration | | ||
| Qualcomm NPU | Android | NPU | Qualcomm SoCs | | ||
| MediaTek NPU | Android | NPU | MediaTek SoCs | | ||
| ARM Ethos-U | Embedded | NPU | ARM MCUs | | ||
| ARM VGF | Android | NPU | ARM platforms | | ||
| OpenVINO | Embedded | CPU/GPU/NPU | Intel SoCs | | ||
| NXP NPU | Embedded | NPU | NXP SoCs | | ||
| Cadence DSP | Embedded | DSP | DSP-optimized workloads | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove NPU, DSP suffix from the first row?
docs/source/index.md
Outdated
|
||
--- | ||
|
||
## 🎯 Recent Wins & Success Stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## 🎯 Recent Wins & Success Stories | |
## 🎯 Wins & Success Stories |
docs/source/index.md
Outdated
|
||
--- | ||
|
||
### Documentation Sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this title
@digantdesai Addressed all your comments |
@pytorchbot cherry-pick --onto release/1.0 -c docs |
### Summary [PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines. [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests). ### Test plan [PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable. (cherry picked from commit 270873f)
Cherry picking #14720The cherry pick PR is at #14830 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>
line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.