Skip to content

update lama export DS specs to be more accurate. #14737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

update lama export DS specs to be more accurate. #14737

merged 1 commit into from
Oct 2, 2025

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Oct 2, 2025 •
edited
Loading

Summary:
this PR pytorch/pytorch#164075 enhances value range analysis discovering a problem in the current upper bounds for DS specs for lama.

This blocks landing the PR above.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14737

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 52 Pending

As of commit 2ca38da with merge base 0882c9b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@facebook-github-bot
Copy link
Contributor

@laithsakka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83708583.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

laithsakka added a commit to laithsakka/executorch that referenced this pull request Oct 2, 2025
@laithsakka @facebook-github-bot
update lama export DS specs to be more accurate. (pytorch#14737)
0a34575 
Summary:

this PR pytorch/pytorch#164075  enhance value range analysis discovering a problem in the current upper bounds for DS specs for lama
full DS logs if someone want to understand why in details
https://www.internalfb.com/phabricator/paste/view/P1973006378

This blocks landing the PR above.

Differential Revision: D83708583
larryliu0820
larryliu0820 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@laithsakka @facebook-github-bot
update lama export DS specs to be more accurate. (pytorch#14737)
2ca38da 
Summary:

this PR pytorch/pytorch#164075  enhance value range analysis discovering a problem in the current upper bounds for DS specs for lama
full DS logs if someone want to understand why in details
https://www.internalfb.com/phabricator/paste/view/P1973006378

This blocks landing the PR above.

Reviewed By: angelayi, larryliu0820

Differential Revision: D83708583
@facebook-github-bot facebook-github-bot merged commit deb42f2 into pytorch:main Oct 2, 2025
130 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@angelayi angelayi angelayi approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laithsakka @facebook-github-bot @larryliu0820 @angelayi