Skip to content

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Oct 2, 2025

Add a new argument to common.parametrize, flakies, which selects which parametrized test cases to mark as flaky. With this new argument, mark the test test_bmm.py::test_bmm_vgf_FP_single_input[rand_big_1] as flaky.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add a new argument to `common.parametrize`, `flakies`, which selects
which parametrized test cases to mark as flaky. With this new argument,
mark the test test_bmm.py::test_bmm_vgf_FP_single_input[rand_big_1] as
flaky.

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: I88237714dbc21edcf860947c7b538fe5d9dbdc37
@martinlsm martinlsm requested a review from digantdesai as a code owner October 2, 2025 10:33
Copy link

pytorch-bot bot commented Oct 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14748

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c6e9d0b with merge base 3b16bc1 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the recommended pytest way to selectively mark flaky from "parameterized" inputs? Just curious.

@zingo zingo merged commit 7d8da19 into pytorch:main Oct 7, 2025
279 of 281 checks passed
@martinlsm
Copy link
Collaborator Author

martinlsm commented Oct 8, 2025

Is this the recommended pytest way to selectively mark flaky from "parameterized" inputs? Just curious.

@digantdesai Good question. Since we are wrapping the parametrization decorator anyways, I thought it was easiest to just extend it like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants