-
Notifications
You must be signed in to change notification settings - Fork 684
Arm backend: Mark test in test_bmm.py as flaky #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a new argument to `common.parametrize`, `flakies`, which selects which parametrized test cases to mark as flaky. With this new argument, mark the test test_bmm.py::test_bmm_vgf_FP_single_input[rand_big_1] as flaky. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I88237714dbc21edcf860947c7b538fe5d9dbdc37
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14748
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c6e9d0b with merge base 3b16bc1 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label ciflow/trunk |
@pytorchbot label "partner: arm" |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the recommended pytest way to selectively mark flaky from "parameterized" inputs? Just curious.
@digantdesai Good question. Since we are wrapping the parametrization decorator anyways, I thought it was easiest to just extend it like this. |
Add a new argument to
common.parametrize
,flakies
, which selects which parametrized test cases to mark as flaky. With this new argument, mark the test test_bmm.py::test_bmm_vgf_FP_single_input[rand_big_1] as flaky.cc @digantdesai @freddan80 @per @zingo @oscarandersson8218