Skip to content

add remove clone in pre edge #14785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

add remove clone in pre edge #14785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions backends/transforms/test/test_remove_clone_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,13 @@ def test_clone_identity_removed(self):
exported,
compile_config=EdgeCompileConfig(_skip_dim_order=skip_dim_order),
)
# Early exit if clone_op_str is not present in the graph
# This is because some other pass may have removed the clone op.
before_gm_code = before_epm.exported_program().graph_module.code
if clone_op_str not in before_gm_code:
continue

FileCheck().check_count(clone_op_str, 1, exactly=True).run(
before_epm.exported_program().graph_module.code
)
FileCheck().check_count(clone_op_str, 1, exactly=True).run(before_gm_code)

updated_epm = before_epm.transform([RemoveCloneOpsTransform()])

Expand Down
5 changes: 4 additions & 1 deletion exir/passes/remove_noop_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ def call(self, graph_module: GraphModule) -> PassResult:
if node.op != "call_function":
continue

if node.target not in (torch.ops.aten._to_copy.default,):
if node.target not in (
torch.ops.aten._to_copy.default,
torch.ops.aten.clone.default,
):
continue

orig_tensor = node.args[0].meta["val"]
Expand Down
Loading