Add lru_cache for node comparison #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48708658 |
Summary: Pull Request resolved: pytorch/executorch#148 cache the args to optimize the number of calls. For `is_same_node` function, we're expecting the same results each time it's called with the same inputs. For mv2, ``` buck run mode/dev-nosan //executorch/examples/backend:xnnpack_examples -- -m mv2 -q -d ``` The total number of nodes in mv2 graph after quantize is 520. Before the change: mv2: The number of call to `is_same_node` is 6388036 🙈 mv2: to_backend call time: 30.79 second (including dumping the logs) mv3: takes forever After the change: mv2: The number of call to `is_same_node` is 520. It's more reasonable mv2: to_backend call time: 10.15 second (including dumping the logs) mv3: `to_backend` call takes 16 second. Reviewed By: digantdesai, mcr229 Differential Revision: D48708658 fbshipit-source-id: ce2b7f5835ed17fa6df75a3bfcee495b2ab0a4a2
|
This pull request was exported from Phabricator. Differential Revision: D48708658 |
cccclai
force-pushed
the
export-D48708658
branch
from
923f1b0 to
ecabe75
Compare
|
This pull request has been merged in 7299bf3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
cache the args to optimize the number of calls. For
is_same_nodefunction, we're expecting the same results each time it's called with the same inputs.For mv2,
The total number of nodes in mv2 graph after quantize is 520.
Before the change:
mv2: The number of call to
is_same_nodeis 6388036 🙈mv2: to_backend call time: 30.79 second (including dumping the logs)
mv3: takes forever
After the change:
mv2: The number of call to
is_same_nodeis 520. It's more reasonablemv2: to_backend call time: 10.15 second (including dumping the logs)
mv3:
to_backendcall takes 16 second.Reviewed By: digantdesai, mcr229
Differential Revision: D48708658