Skip to content

oss et update to support SAR2230P #14808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

oss et update to support SAR2230P #14808

merged 1 commit into from
Oct 7, 2025
+5 −0

Conversation

billmguo
Copy link
Contributor

@billmguo billmguo commented Oct 5, 2025 •
edited by pytorch-bot bot
Loading

Summary: OSS ET update to support SAR2230P

Differential Revision: D83934187

cc @cccclai @winskuo-quic @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin

@billmguo billmguo requested a review from cccclai as a code owner October 5, 2025 18:40
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14808

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f98890a with merge base c609f63 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2025
@facebook-github-bot
Copy link
Contributor

@billmguo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83934187.

@billmguo
Copy link
Contributor Author

billmguo commented Oct 5, 2025

@pytorchbot label "topic: not user facing"

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin added the partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm label Oct 6, 2025
@cccclai
Copy link
Contributor

cccclai commented Oct 6, 2025

Lots of tests are failing, can you fix them?

@limintang limintang self-requested a review October 6, 2025 18:06
limintang
limintang reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@limintang limintang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add V81 = 81 to class HtpArch to fix the test failures.

billmguo added a commit to billmguo/executorch that referenced this pull request Oct 6, 2025
@billmguo @facebook-github-bot
oss et update to support SAR2230P (pytorch#14808)
f95e20d 
Summary:

OSS ET update to support SAR2230P

Differential Revision: D83934187
@meta-codesync Meta CodeSync
Copy link

meta-codesync bot commented Oct 6, 2025

@billmguo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83934187.

billmguo added a commit to billmguo/executorch that referenced this pull request Oct 6, 2025
@billmguo @facebook-github-bot
oss et update to support SAR2230P (pytorch#14808)
adf2fbf 
Summary:

OSS ET update to support SAR2230P

Differential Revision: D83934187
billmguo added a commit to billmguo/executorch that referenced this pull request Oct 7, 2025
@billmguo @facebook-github-bot
oss et update to support SAR2230P (pytorch#14808)
dc1665f 
Summary:

OSS ET update to support SAR2230P

Differential Revision: D83934187
@billmguo @facebook-github-bot
oss et update to support SAR2230P (pytorch#14808)
f98890a 
Summary:

OSS ET update to support SAR2230P

Differential Revision: D83934187
shewu-quic
shewu-quic reviewed Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add SAR2230P in qc_compiler_spec.fbs and backends/qualcomm/utils/utils.py.
Thanks!

@meta-codesync meta-codesync bot merged commit 0b748bf into pytorch:main Oct 7, 2025
131 of 133 checks passed
@cccclai
Copy link
Contributor

cccclai commented Oct 7, 2025 •
edited
Loading

Revert in #14859 for two reasons

  • missing changes for supporting new SoCs
  • this change require qnn 2.39

Let's test the PR in a real device and then merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limintang limintang limintang approved these changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

@chenweng-quic chenweng-quic Awaiting requested review from chenweng-quic

+1 more reviewer

@shewu-quic shewu-quic shewu-quic left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@billmguo @facebook-github-bot @cccclai @limintang @shewu-quic @mergennachin