Skip to content

Conversation

DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Oct 7, 2025

Summary: The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now.

Reviewed By: ethansfng

Differential Revision: D83873937

Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14857

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit d1491bd with merge base 0bfb61e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025
Copy link

meta-codesync bot commented Oct 7, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83873937.

Copy link

github-actions bot commented Oct 7, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Oct 7, 2025
Summary:

The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now.

Reviewed By: ethansfng

Differential Revision: D83873937
Summary:

The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now.

Reviewed By: ethansfng

Differential Revision: D83873937
@meta-codesync meta-codesync bot merged commit 15a203b into pytorch:main Oct 7, 2025
131 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants