-
Notifications
You must be signed in to change notification settings - Fork 684
Update XNNPACK doc structure and add template #14873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14873
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 3 PendingAs of commit 592f698 with merge base 019c8da ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This is a pretty early draft, but I'd be interested in any thoughts. |
15169b1
to
bd30b09
Compare
bd30b09
to
42a6b71
Compare
docs/source/backends-overview.md
Outdated
| Backend | Platform(s) | Hardware Type | Typical Use Case | | ||
|-----------------------------------------------|---------------------|---------------|---------------------------------| | ||
| [XNNPACK](backends/xnnpack/xnnpack-overview) | All | CPU | General-purpose, fallback | | ||
| [Core ML](backends-coreml) | iOS, macOS | NPU/GPU | Apple devices, high performance | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoreML is CPU too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments.
@@ -0,0 +1,3 @@ | |||
# Using {FEATURE} on {BACKEND_NAME} | |||
|
|||
This is a placeholder guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add meta details about the intended use of this section?
|
||
## Step 1: Environment Setup | ||
|
||
This tutorial is intended to be run from a {SUPPORTED_HOST_OS} and uses Conda for Python environment management. For full setup details and system requirements, see [Getting Started with ExecuTorch](/getting-started). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
42a6b71
to
b577bd8
Compare
b577bd8
to
67f0493
Compare
67f0493
to
592f698
Compare
:hidden: | ||
:caption: {BACKEND} Backend | ||
backend-troubleshooting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: do you wanna put the troubleshooting section a bit further back in the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we went back and forth (literally on the list too :p)
backend-troubleshooting | ||
backend-partitioner | ||
backend-quantization | ||
backend-op-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking more, technically op-support can be under partitioner.
So thinking out loud,
- partitioner, quantizer (two entry point, separate pages)
- tutorials (curious why it is not here?)
- internals (can also house reference material facts which can't be part of parishioner or quantizer)
- guide/troubleshooting/gotcha/faq (one page with a title reflecting it is for all these :p)
Under Edge Platforms (iOS, Android, Desktop, C++) etc I don't see XNNPACK anymore on the left nav "Edge->Android->Backends", as well as the overview page https://docs-preview.pytorch.org/pytorch/executorch/14873/android-backends.html (no link to XNNPACK) https://docs-preview.pytorch.org/pytorch/executorch/14873/android-section.html (no XNNPACK on left nav) |
Summary: Title says it all! Add docs for the Samsung backend based on the template introduced in #14873.
Summary
Prototype an updated doc structure for the XNNPACK backend. Extract a common template out under docs/source/backends/tempate/
This PR updates the doc structure as follows. Under the template, the landing page is required, partitioner, quantization, and op support docs are recommended, and the rest are optional.