Skip to content

Conversation

haowhsu-quic
Copy link
Collaborator

Summary

  • refactor a bit & add more test cases

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put -b build-android -s $SN -m SM8750
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put_suite -b build-android -s $SN -m SM8750

- refactor a bit & add more test cases
@haowhsu-quic haowhsu-quic requested a review from cccclai as a code owner October 9, 2025 01:23
Copy link

pytorch-bot bot commented Oct 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14924

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 4b127ba with merge base 38b51aa (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
@haowhsu-quic
Copy link
Collaborator Author

Hi @cccclai, I 've tried all the input configurations in suite test and only 1 sub test was not supported by HTP. Hopefully this could increase the coverage.

@haowhsu-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Oct 9, 2025
mean_dims = [dim_arg]
else:
mean_dims = list(dim_arg)
print("mean_dims: ", mean_dims, "rank: ", rank)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, forget to delete this line

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cccclai
Copy link
Contributor

cccclai commented Oct 9, 2025

I add the nightly label such that we can see the result reported from the test suite

Copy link

meta-codesync bot commented Oct 9, 2025

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D84224945.

@haowhsu-quic
Copy link
Collaborator Author

I add the nightly label such that we can see the result reported from the test suite

Thanks! The report only shows 2 fail cases now due to the unsupported dimension in HTP, which is expected.

@cccclai cccclai merged commit 019c8da into pytorch:main Oct 11, 2025
185 of 190 checks passed
@cccclai
Copy link
Contributor

cccclai commented Oct 11, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

pytorchbot pushed a commit that referenced this pull request Oct 11, 2025
### Summary
- refactor a bit & add more test cases

### Test plan
```bash
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put -b build-android -s $SN -m SM8750
python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put_suite -b build-android -s $SN -m SM8750
```

(cherry picked from commit 019c8da)
@pytorchbot
Copy link
Collaborator

Cherry picking #14924

The cherry pick PR is at #15038 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

JacobSzwejbka added a commit that referenced this pull request Oct 13, 2025
JacobSzwejbka added a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants