-
Notifications
You must be signed in to change notification settings - Fork 684
Qualcomm AI Engine Direct - increase index_put coverage #14924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- refactor a bit & add more test cases
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14924
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 4b127ba with merge base 38b51aa ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @cccclai, I 've tried all the input configurations in suite test and only 1 sub test was not supported by HTP. Hopefully this could increase the coverage. |
@pytorchbot label "release notes: qualcomm" |
mean_dims = [dim_arg] | ||
else: | ||
mean_dims = list(dim_arg) | ||
print("mean_dims: ", mean_dims, "rank: ", rank) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, forget to delete this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I add the nightly label such that we can see the result reported from the test suite |
Thanks! The report only shows 2 fail cases now due to the unsupported dimension in HTP, which is expected. |
@pytorchbot cherry-pick --onto release/1.0 -c regression |
### Summary - refactor a bit & add more test cases ### Test plan ```bash python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put -b build-android -s $SN -m SM8750 python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperator.test_qnn_backend_index_put_suite -b build-android -s $SN -m SM8750 ``` (cherry picked from commit 019c8da)
Cherry picking #14924The cherry pick PR is at #15038 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
…)" This reverts commit 019c8da.
…)" This reverts commit 019c8da.
Summary
Test plan