Add -fexceptions to quantized kernel generated libs #14962
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14962
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 2 Unrelated FailuresAs of commit 600c480 with merge base fca0f38 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@Daksh-Shami has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84284541. |
This PR needs a
|
|
@pytorchbot label "release notes: build warnings" |
|
Didn't find following labels among repository labels: release notes: build warnings |
Daksh-Shami
force-pushed
the
export-D84284541
branch
from
3a0b7cb to
6dfc3b3
Compare
Daksh-Shami
added a commit
to Daksh-Shami/executorch
that referenced
this pull request
Oct 10, 2025
Summary:
Added compiling with `-fexceptions` since quantized kernels have exception based code in them. Example error:
```
buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable
77 | } catch (const std::exception& ex) {
|
```
This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.
Differential Revision: D84284541
swolchok
requested changes
Oct 10, 2025
…14962) Summary: Explicitly turning exception generated code off for quantized kernels as executorch does not use exceptions in general, and it can cause downstream errors. Detailed error is P1986979595 but the relevant part is: ``` buck-out/ABC/gen/fbsource/6e53edb0a9a0d828/xplat/executorch/kernels/quantized/__generated_lib_combined__/out/RegisterCodegenUnboxedKernelsEverything.cpp:77:44: error: exception handling disabled, use '-fexceptions' to enable 77 | } catch (const std::exception& ex) { | ``` This means the generated code uses exceptions in its code, so we should explicitly turn them off. Differential Revision: D84284541
Daksh-Shami
force-pushed
the
export-D84284541
branch
from
6dfc3b3 to
600c480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added compiling with
-fexceptionssince quantized kernels have exception based code in them. Example error:This means the generated code uses exceptions in its code, so we should explicitly flag it to the compiler via the relevant BUCK targets.
Differential Revision: D84284541