Skip to content

backends/cuda: use async malloc/free #14976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
+8 −5
Merged

backends/cuda: use async malloc/free #14976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions backends/cuda/runtime/shims/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ AOTITorchError aoti_torch_empty_strided(

if (device_type == static_cast<int32_t>(SupportedDevices::CUDA)) {
ET_CUDA_CHECK_OR_RETURN_ERROR(
cudaMallocManaged(&ptr, static_cast<size_t>(nbytes)));
cudaMallocAsync(&ptr, static_cast<size_t>(nbytes), cudaStreamDefault));
} else if (device_type == static_cast<int32_t>(SupportedDevices::CPU)) {
// Ensure 16-byte alignment for CPU memory to match CUDA requirements
int result = posix_memalign(&ptr, 16, nbytes);
Expand Down Expand Up @@ -328,11 +328,14 @@ AOTITorchError aoti_torch_delete_tensor_object(Tensor* tensor) {
ET_CUDA_CHECK_OR_RETURN_ERROR(
cudaPointerGetAttributes(&attributes, data_ptr));

if (attributes.type == cudaMemoryTypeManaged) {
// This is CUDA managed memory - free with proper synchronization
ET_CUDA_CHECK_OR_RETURN_ERROR(cudaDeviceSynchronize());
ET_CUDA_CHECK_OR_RETURN_ERROR(cudaFree(data_ptr));
if (attributes.type == cudaMemoryTypeDevice) {
ET_CUDA_CHECK_OR_RETURN_ERROR(
cudaFreeAsync(data_ptr, cudaStreamDefault));
} else {
ET_CHECK_OR_RETURN_ERROR(
attributes.type != cudaMemoryTypeManaged,
Internal,
"Expected host memory but got managed!")
// This is CPU memory - free immediately
free(data_ptr);
data_ptr = nullptr;
Expand Down
Loading