Migrate additional tests to support non-fatal kernels. #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1770
Note: Links to docs will display an error until the docs builds have been completed. ❌ 28 New FailuresAs of commit eb67ba3 with merge base 568673e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53251417 |
GregoryComer
force-pushed
the
export-D53251417
branch
from
a2c3872 to
a886c56
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
export-D53251417
branch
from
a886c56 to
1c79ece
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
export-D53251417
branch
from
1c79ece to
8486b72
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: D53251417 Pulled By: GregoryComer
|
This pull request was exported from Phabricator. Differential Revision: D53251417 |
GregoryComer
force-pushed
the
export-D53251417
branch
from
8486b72 to
0d1243e
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: D53251417 Pulled By: GregoryComer
|
This pull request was exported from Phabricator. Differential Revision: D53251417 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Feb 26, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 8, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Mar 13, 2024
Summary: Note to reviewers: Because the changeset for non-fatal touches so many files, I've split into a number of diffs. The tests will not all pass until the final diff, given that non-fatal tests are switched on in the first diff but tests are not updated until the respective later diff. See revision 6.6 of D53251417 to observe the full change-set passing CI. Pull Request resolved: pytorch#1770 Test Plan: buck2 test mode/dev-nosan kernels/test: Differential Revision: https://internalfb.com/D53251417 Pulled By: GregoryComer
|
@GregoryComer merged this pull request in 72b369d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: buck2 test mode/dev-nosan kernels/test:
Differential Revision: D53251417