-
Notifications
You must be signed in to change notification settings - Fork 645
Run lintrunner on CI #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Run lintrunner on CI #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Sep 11, 2023
guangy10
reviewed
Sep 11, 2023
guangy10
approved these changes
Sep 12, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Summary: Pretty big bang fix for all existing linter issues captured by #266. They are: * F401 imported but unused * B028 No explicit stacklevel argument found * C901 too complex (ignored with `# noqa: C901`) * C419 Unnecessary list comprehension * F841 local variable is assigned to but never used * B023 Function definition does not bind loop variable (only once in `backends/xnnpack/test/test_xnnpack_quantized.py`) * EXE001 Shebang is present but the file is not executable ### Testing All tests pass on CI and `lintrunner --all-files -a` passes locally. Test Plan: `arc lint` && `lintrunner --all-files -a` locally Reviewed By: guangy10 Differential Revision: D49175246 Pulled By: huydhn
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Summary: Pretty big bang fix for all existing linter issues captured by #266. They are: * F401 imported but unused * B028 No explicit stacklevel argument found * C901 too complex (ignored with `# noqa: C901`) * C419 Unnecessary list comprehension * F841 local variable is assigned to but never used * B023 Function definition does not bind loop variable (only once in `backends/xnnpack/test/test_xnnpack_quantized.py`) * EXE001 Shebang is present but the file is not executable ### Testing All tests pass on CI and `lintrunner --all-files -a` passes locally. Pull Request resolved: #275 Test Plan: `arc lint` && `lintrunner --all-files -a` locally Reviewed By: guangy10 Differential Revision: D49175246 Pulled By: huydhn fbshipit-source-id: 1d035dd791f9bdafbae14b6d9132e8ca6cf52b9f
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* bring back runner-et test * mac * return state to before for sanity check * change to using Util functions for x-platform support. Add mac/linux runners * mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of flake8 errors which I'll fix in a different PR and land them together to avoid complicating this one
Testing
https://github.com/pytorch/executorch/actions/runs/6152384722