Skip to content

Run lintrunner on CI #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Run lintrunner on CI #266

wants to merge 11 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 11, 2023

There are a bunch of flake8 errors which I'll fix in a different PR and land them together to avoid complicating this one

Testing

https://github.com/pytorch/executorch/actions/runs/6152384722

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2023
@huydhn huydhn marked this pull request as ready for review September 11, 2023 22:36
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 12, 2023
Summary:
Pretty big bang fix for all existing linter issues captured by #266.  They are:

* F401 imported but unused
* B028 No explicit stacklevel argument found
* C901 too complex (ignored with `# noqa: C901`)
* C419 Unnecessary list comprehension
* F841 local variable is assigned to but never used
* B023 Function definition does not bind loop variable (only once in `backends/xnnpack/test/test_xnnpack_quantized.py`)
* EXE001 Shebang is present but the file is not executable

### Testing

All tests pass on CI and `lintrunner --all-files -a` passes locally.


Test Plan: `arc lint` && `lintrunner --all-files -a` locally

Reviewed By: guangy10

Differential Revision: D49175246

Pulled By: huydhn
facebook-github-bot pushed a commit that referenced this pull request Sep 12, 2023
Summary:
Pretty big bang fix for all existing linter issues captured by #266.  They are:

* F401 imported but unused
* B028 No explicit stacklevel argument found
* C901 too complex (ignored with `# noqa: C901`)
* C419 Unnecessary list comprehension
* F841 local variable is assigned to but never used
* B023 Function definition does not bind loop variable (only once in `backends/xnnpack/test/test_xnnpack_quantized.py`)
* EXE001 Shebang is present but the file is not executable

### Testing

All tests pass on CI and `lintrunner --all-files -a` passes locally.

Pull Request resolved: #275

Test Plan: `arc lint` && `lintrunner --all-files -a` locally

Reviewed By: guangy10

Differential Revision: D49175246

Pulled By: huydhn

fbshipit-source-id: 1d035dd791f9bdafbae14b6d9132e8ca6cf52b9f
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 0c1d726.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
* bring back runner-et test

* mac

* return state to before for sanity check

* change to using Util functions for x-platform support.  Add mac/linux runners

* mac
@huydhn huydhn deleted the lintrunner-ci branch August 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants