Skip to content

Add delegate time scale converter to Inspector #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add delegate time scale converter to Inspector #3297

merged 1 commit into from
Apr 24, 2024

Conversation

pytorchbot
Copy link
Collaborator

Differential Revision: D55298701

@tarun292 @pytorchbot
Add delegate time scale converter to Inspector (#3240)
2dc0c51 
Summary:
Pull Request resolved: #3240

The time scale of delegate events reported might be different from the timescale of CPU events. This diff adds support for providing a callable that can be invoked by Inspector to modify the timescale of delegated events to ensure consistency in timescales across delegated and non-delegated events.

Reviewed By: Jack-Khuu

Differential Revision: D55298701

fbshipit-source-id: e888e51b602c7e1ec8cb9e05ac052280daa12823
(cherry picked from commit b7b40ac)
@pytorchbot pytorchbot mentioned this pull request Apr 24, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3297

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2dc0c51 with merge base d3326a2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@tarun292 tarun292 mentioned this pull request Apr 24, 2024
Closed
@guangy10 guangy10 merged commit 759fd12 into release/0.2 Apr 24, 2024
@mergennachin mergennachin mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guangy10 guangy10 guangy10 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pytorchbot @guangy10 @facebook-github-bot @tarun292