Dtype selective build refactor #3938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3938
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c7d0f8f with merge base 7f0c0b8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 12, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
larryliu0820
approved these changes
Jun 13, 2024
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
Summary: Pull Request resolved: pytorch#3938 1. Add dtype_selective_build as an option to executorch_generated_lib 2. Copy portable source and header files into codegen.bzl directory (this is the caller's directory, eg. examples/selective_build) 3. If kernel_deps contains portable_ops, remove it and use the source files Note: dtype selective build only available for xplat. `header_namespace` is only available in xplat, used to link headers into correct place. ``` error: fail: cpp_library(): the `header_namespace` parameter is *not* supported in fbcode -- `#include` paths must match their fbcode-relative path. (executorch/backends/vulkan/serialization/schema/vk_delegate_schema) ``` New API usage: ``` executorch_generated_lib( ... dtype_selective_build = True, ... ) ``` Reviewed By: larryliu0820 Differential Revision: D58396325
|
This pull request was exported from Phabricator. Differential Revision: D58396325 |
|
This pull request has been merged in 1547bcf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Note: dtype selective build only available for xplat.
header_namespaceis only available in xplat, used to link headers into correct place.Reviewed By: larryliu0820
Differential Revision: D58396325