Skip to content

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Aug 3, 2024

Summary:
Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai

Differential Revision: D60323282

Differential Revision: D58903230
Copy link

pytorch-bot bot commented Aug 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4539

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9570e7d with merge base 864e0b0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

mcr229 added 3 commits August 5, 2024 09:35
…NNPartitioner

Summary:
Following up on the Configeration based Partitioner,

We introduce the XnnpackPartitioner as a configeration based partitioner, along with a linear config. This passes all fp32 linear tests for XNNPACK

Differential Revision: D58903233
Summary:
Pull Request resolved: pytorch#4374

We refactor the quant utils file to have more functions:
- is_quant
- is_dequant
- is_qparam
- is_dynamic_q
- is_getitem

Additionally, we use format_target_name so that the targets are now agnostice of aten or edge dialect

Differential Revision: D59707641
mcr229 added a commit to mcr229/executorch that referenced this pull request Aug 5, 2024
Summary:
Pull Request resolved: pytorch#4539

Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai, kirklandsign

Differential Revision: D60323282
@mcr229 mcr229 force-pushed the export-D60323282 branch from 596f495 to 2c18e1d Compare August 5, 2024 16:42
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

mcr229 added a commit to mcr229/executorch that referenced this pull request Aug 5, 2024
Summary:
Pull Request resolved: pytorch#4539

Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai, kirklandsign

Differential Revision: D60323282
@mcr229 mcr229 force-pushed the export-D60323282 branch from 2c18e1d to 2e64e7a Compare August 5, 2024 16:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

mcr229 added a commit to mcr229/executorch that referenced this pull request Aug 5, 2024
Summary:
Pull Request resolved: pytorch#4539

Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai, kirklandsign

Differential Revision: D60323282
@mcr229 mcr229 force-pushed the export-D60323282 branch from 2e64e7a to e3e5fd2 Compare August 5, 2024 16:51
mcr229 added 6 commits August 5, 2024 11:35
…h#4373)

Summary:
Pull Request resolved: pytorch#4373

Adding `GEMMConfig(XNNPartitionerConfig)`

This is a base class which handles grabbing all the dependencies of a gemm like node (conv, addmm, linear) and then validates that the node is a valid partition.

We modify all tests in the linear, and validate that to_edge_transform_and_lower with the new partitioner works with all nodes. Additionally, we add a `SingleNodePartitionerConfig` class for simple nodes like q_per_tensor and dq_per_tensor. This helps partition q_per_tensor/dq_per_tensor nodes which are actually explicilty converting the dtype of the input.

Differential Revision: D58903231
Differential Revision: D59833087
Differential Revision: D59833165
Differential Revision: D60125953
Summary: Pull Request resolved: pytorch#4368

Differential Revision: D60125954
Differential Revision: D60323283
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

mcr229 added a commit to mcr229/executorch that referenced this pull request Aug 5, 2024
Summary:
Pull Request resolved: pytorch#4539

Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai, kirklandsign

Differential Revision: D60323282
@mcr229 mcr229 force-pushed the export-D60323282 branch from e3e5fd2 to 402505a Compare August 5, 2024 18:47
Summary:
Pull Request resolved: pytorch#4539

Div Mul, Elu partitioner configs

This enables Elu because we can prevent its decomposition

Reviewed By: digantdesai, kirklandsign

Differential Revision: D60323282
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60323282

@mcr229 mcr229 force-pushed the export-D60323282 branch from 402505a to 9570e7d Compare August 5, 2024 18:53
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a0d63cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants