Skip to content

Conversation

neuropilot-captain
Copy link
Collaborator

Redirect third-party lib (abseil-cpp, re2) source to 'extension'

Copy link

pytorch-bot bot commented Aug 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures, 1 Unrelated Failure

As of commit 45f66eb with merge base 8471c22 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2024
@digantdesai digantdesai added the partner: mediatek Issues related to the Mediatek delegate label Aug 21, 2024
#include <executorch/examples/models/llama2/tokenizer/tiktoken.h>
#include <executorch/extension/llm/tokenizer/bpe_tokenizer.h>
#include <executorch/extension/llm/tokenizer/tiktoken.h>
#include <executorch/examples/models/llama2/tokenizer/llama_tiktoken.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix linter error?

#include <executorch/examples/models/llama2/tokenizer/llama_tiktoken.h>
#include <executorch/extension/llm/tokenizer/bpe_tokenizer.h>
#include <executorch/extension/llm/tokenizer/tiktoken.h>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@digantdesai
Copy link
Contributor

Seems like the linter job is still failing?

@kirklandsign
Copy link
Contributor

Seems like the linter job is still failing?

Needs a rebase. I wouldn't worry about this one. It doesn't touch java code

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@cccclai
Copy link
Contributor

cccclai commented Aug 27, 2024

Looks like unrelated CI failure

@cccclai cccclai merged commit 3fb03dc into pytorch:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: mediatek Issues related to the Mediatek delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants