-
Notifications
You must be signed in to change notification settings - Fork 684
Fix llama runner build #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix llama runner build #4817
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4817
Note: Links to docs will display an error until the docs builds have been completed. ❌ 27 New Failures, 1 Unrelated FailureAs of commit 45f66eb with merge base 8471c22 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
#include <executorch/examples/models/llama2/tokenizer/tiktoken.h> | ||
#include <executorch/extension/llm/tokenizer/bpe_tokenizer.h> | ||
#include <executorch/extension/llm/tokenizer/tiktoken.h> | ||
#include <executorch/examples/models/llama2/tokenizer/llama_tiktoken.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix linter error?
#include <executorch/examples/models/llama2/tokenizer/llama_tiktoken.h>
#include <executorch/extension/llm/tokenizer/bpe_tokenizer.h>
#include <executorch/extension/llm/tokenizer/tiktoken.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem
Seems like the linter job is still failing? |
Needs a rebase. I wouldn't worry about this one. It doesn't touch java code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Looks like unrelated CI failure |
Redirect third-party lib (abseil-cpp, re2) source to 'extension'