Skip to content

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Aug 24, 2024

Description

For release build, since --gc-sections is not supported by clang, use the equivalent, which is -dead_strip (source).

Closes #4874

Test plan

Tested manually:

./.ci/scripts/test_llava.sh Release

@jackzhxng jackzhxng requested a review from larryliu0820 August 24, 2024 00:55
Copy link

pytorch-bot bot commented Aug 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4888

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c5c7d5a with merge base 6feb639 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2024
@jackzhxng jackzhxng marked this pull request as ready for review August 24, 2024 05:54
@facebook-github-bot
Copy link
Contributor

@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jackzhxng jackzhxng force-pushed the jackxz/clang-gc-sections branch from e35aefd to 3ad2959 Compare August 26, 2024 16:13
@facebook-github-bot
Copy link
Contributor

@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng jackzhxng force-pushed the jackxz/clang-gc-sections branch from 3ad2959 to dd6d21c Compare August 26, 2024 20:57
@jackzhxng
Copy link
Contributor Author

Update: I think dead_strip is for macos, not for clang. Trying if(APPLE) instead.

@facebook-github-bot
Copy link
Contributor

@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 4689c91 into main Aug 26, 2024
@facebook-github-bot facebook-github-bot deleted the jackxz/clang-gc-sections branch August 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link error when building llava runner in Release mode

3 participants