-
Notifications
You must be signed in to change notification settings - Fork 684
Swap --gc-sections to -dead_strip for clang compilation #4888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4888
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c5c7d5a with merge base 6feb639 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
e35aefd
to
3ad2959
Compare
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3ad2959
to
dd6d21c
Compare
Update: I think |
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Description
For release build, since
--gc-sections
is not supported by clang, use the equivalent, which is-dead_strip
(source).Closes #4874
Test plan
Tested manually: