enable parallel prefill again #4893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4893
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b03e7f2 with merge base 801e1c9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61751873 |
larryliu0820
approved these changes
Aug 26, 2024
kimishpatel
force-pushed
the
export-D61751873
branch
from
b65977b to
91d1a02
Compare
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#4893 Accidentally the parallel prefill enablement logic fell through the cracks before {F1823815458} after {F1823818585} Observe the calls to 4x8 kernels Reviewed By: swolchok, larryliu0820 Differential Revision: D61751873
|
This pull request was exported from Phabricator. Differential Revision: D61751873 |
Summary: Pull Request resolved: pytorch#4893 Accidentally the parallel prefill enablement logic fell through the cracks before {F1823815458} after {F1823818585} Observe the calls to 4x8 kernels Reviewed By: swolchok, larryliu0820 Differential Revision: D61751873
|
This pull request was exported from Phabricator. Differential Revision: D61751873 |
kimishpatel
force-pushed
the
export-D61751873
branch
from
91d1a02 to
b03e7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Accidentally the parallel prefill enablement logic fell through the cracks
before
{F1823815458}
after
{F1823818585}
Observe the calls to 4x8 kernels
Reviewed By: swolchok
Differential Revision: D61751873