Skip to content

Allow EValue to be constructed with a smart pointer implicitly. #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

Allow EValue to be constructed with a smart pointer implicitly. #4902

merged 1 commit into from
Aug 27, 2024

Conversation

shoumikhin
Copy link
Contributor

Differential Revision: D61783902

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4902

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9f33a18 with merge base da2142b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

9 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@shoumikhin @facebook-github-bot
Allow EValue to be constructed with a smart pointer implicitly. (#4902)
9f33a18 
Summary:
Pull Request resolved: #4902

Consider https://github.com/pytorch/executorch/blob/dc66414c70dbec763fa37aba7908d50373299435/examples/models/llava/runner/llava_image_prefiller.h#L31-L33, if the ManagedTensor had an operator* overload, it could have been passed to module.execute directly like `module_->execute(kImageEncoderMethod, managed_images)`.

Reviewed By: dbort

Differential Revision: D61783902
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61783902

@facebook-github-bot facebook-github-bot merged commit 5942e4a into pytorch:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbort dbort dbort approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoumikhin @facebook-github-bot @dbort