[llama] Build the runner with tiktoken by default #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4921
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit dedef9c with merge base 959bb1b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
force-pushed
the
tiktoken_build
branch
from
3999038 to
fe6f4e9
Compare
JacobSzwejbka
approved these changes
Aug 28, 2024
larryliu0820
force-pushed
the
tiktoken_build
branch
from
9faf929 to
a231da6
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
d45a87c to
d34e569
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
d34e569 to
37976b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
37976b0 to
cd69d34
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
cd69d34 to
a0fc553
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
a0fc553 to
74e4bc6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
Summary: As titled. We want to get rid of the preprocessor flag `EXECUTORCH_USE_TIKTOKEN` and build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers. Test Plan: All CI jobs pass Reviewed By: JacobSzwejbka Differential Revision: D61830302 Pulled By: larryliu0820
facebook-github-bot
force-pushed
the
tiktoken_build
branch
from
74e4bc6 to
dedef9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61830302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. We want to get rid of the preprocessor flag
EXECUTORCH_USE_TIKTOKENand build tiktoken tokenizer by default. At model loading time we will try to read the artifact in one of the tokenizers.Test Plan: All CI jobs pass
Reviewers:
Subscribers:
Tasks:
Tags: